Modify

Opened 8 years ago

Closed 8 years ago

#6620 closed enhancement (fixed)

[Patch] Consider positioning `SELECT ALL` on right side of code box

Reported by: Ryan J Ollos Owned by: Alexander Slesarev
Priority: normal Component: CodeExampleMacro
Severity: normal Keywords:
Cc: Trac Release: 0.11

Description

I tend to think the layout would be slightly better if the SELECT ALL was right aligned.

Attachments (2)

RightAlignedSelectAll.png (16.8 KB) - added by Ryan J Ollos 8 years ago.
codeexamplemacro.patch (416 bytes) - added by Ryan J Ollos 8 years ago.

Download all attachments as: .zip

Change History (9)

comment:1 Changed 8 years ago by Ryan J Ollos

Btw, I just opened this ticket in case you agree with the suggestion, it would be great if you could modify the source so that I can keep my local installation in sync with the repository version.

If you prefer the current layout and don't want to make the change, I'll just edit the template on my local installation.

Thanks.

Changed 8 years ago by Ryan J Ollos

Attachment: RightAlignedSelectAll.png added

comment:2 Changed 8 years ago by Ryan J Ollos

I don't do much HTML coding, but it appears that the proper was to do this is to modify the CSS, which is what I did in the attached patch.

I think it makes the layout look a lot better, but its definitely a personal preference.

Changed 8 years ago by Ryan J Ollos

Attachment: codeexamplemacro.patch added

comment:3 Changed 8 years ago by Ryan J Ollos

Summary: Consider positioning `SELECT ALL` on right size of code box[Patch] Consider positioning `SELECT ALL` on right size of code box

comment:4 Changed 8 years ago by Ryan J Ollos

Summary: [Patch] Consider positioning `SELECT ALL` on right size of code box[Patch] Consider positioning `SELECT ALL` on right side of code box

comment:5 Changed 8 years ago by Alexander Slesarev

Fixed in r7617. Thanks for the patch.

comment:6 Changed 8 years ago by Alexander Slesarev

Status: newassigned

comment:7 Changed 8 years ago by Alexander Slesarev

Resolution: fixed
Status: assignedclosed

Modify Ticket

Change Properties
Set your email in Preferences
Action
as closed The owner will remain Alexander Slesarev.
The resolution will be deleted.

Add Comment


E-mail address and name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.