Modify

Opened 7 years ago

Closed 6 years ago

#6656 closed defect (fixed)

UNC path enhancement

Reported by: Ricky Owned by: Christian Boos
Priority: normal Component: WikiGoodiesPlugin
Severity: normal Keywords:
Cc: Trac Release: 0.11

Description

I modified the regular expression to let UNC path to identify path and file name within hard bracket. Such as [\\svr1\work\sixtrak\gateway\ipm_firmware\xvers\etms4_7_1000.fwb Current release firmware] will show Current release firmware as a wiki link. Also if you have space within the URL like ["\\svr1\work\sixtrak\gateway\ipm firmware\xvers\etms4_7_1000.fwb" Current release firmware], you can specify your URL with quotes and it works as well. The diff file is attached

Attachments (1)

unc_patch.diff (1.7 KB) - added by Ricky 7 years ago.
diff file

Download all attachments as: .zip

Change History (4)

Changed 7 years ago by Ricky

Attachment: unc_patch.diff added

diff file

comment:1 Changed 7 years ago by Christian Boos

Thanks for the patch! This probably needs to use trac.util.text.unicode_quote though.

comment:2 Changed 6 years ago by Christian Boos

Status: newassigned

The second suggested form:

["\\svr1\work\sixtrak\gateway\ipm firmware\xvers\etms4_7_1000.fwb" Current release firmware]

will conflict with the one of the internal free link (i.e. a syntax provided by the WikiModule in Trac), so this can't be used.

Instead, I'll add an unc: link resolver:

[unc:"\\svr1\work\sixtrak\gateway\ipm firmware\xvers\etms4_7_1000.fwb" Current release firmware]

comment:3 Changed 6 years ago by Christian Boos

Resolution: fixed
Status: assignedclosed

(In [10300]) WikiGoodiesPlugin: UNC path syntax extended to support [unc_path label] forms.

In more details, the following two new syntaxes are now supported:

[\\svr1\work\sixtrak\gateway\ipm_firmware\xvers\etms4_7_1000.fwb Current release firmware]

and:

[unc:\\svr1\work\sixtrak\gateway\ipm_firmware\xvers\etms4_7_1000.fwb Current release firmware]
[unc:"\\svr1\work\sixtrak\gateway\ipm firmware\xvers\etms4_7_1000.fwb" Current release firmware]

Closes #6656.

Modify Ticket

Change Properties
Set your email in Preferences
Action
as closed The owner will remain Christian Boos.
The resolution will be deleted.

Add Comment


E-mail address and name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.