Modify

Opened 7 years ago

Last modified 2 years ago

#6722 new defect

Themes do not display diffs nicely

Reported by: Malcolm Studd Owned by:
Priority: normal Component: SlideShowPlugin
Severity: normal Keywords:
Cc: Trac Release: 0.11

Description

Create a presentation with a {{{#!diff}}} section. The wiki page displays the diff niceley formatted. The presentation page does not.

Attachments (1)

SlideShowWithDiff.png (50.2 KB) - added by Ryan J Ollos 7 years ago.

Download all attachments as: .zip

Change History (10)

comment:1 Changed 7 years ago by Ryan J Ollos

Acknowledged.

Inserting a diff, such as:

{{{
#!diff
--- trac/wiki/formatter.py	(revision 5695)
+++ trac/wiki/formatter.py	(working copy)
@@ -462,7 +462,7 @@
             type_ = 'ul'
         else:
             type_ = 'ol'
-            idx = '01iI'.find(listid)
+            idx = '0iI'.find(listid)
             if idx >= 0:
                 class_ = ('arabiczero', None, 'lowerroman', 'upperroman')[idx]
             elif listid.isdigit():
}}}

Results in:

Changed 7 years ago by Ryan J Ollos

Attachment: SlideShowWithDiff.png added

comment:3 Changed 7 years ago by Ryan J Ollos

Please let me know if you are seeing any behavior that I did not capture in comment:1 and comment:2, and I'll look into whether this can be fixed.

comment:4 Changed 7 years ago by Malcolm Studd

Yup, that's exactly what I saw.

comment:5 Changed 7 years ago by Ryan J Ollos

Component: S5PluginSlideShowPlugin

comment:6 Changed 6 years ago by Ryan J Ollos

Priority: normalhigh
Status: newassigned

comment:7 Changed 6 years ago by Ryan J Ollos

[9429] may help with this ticket and #6896.

comment:8 Changed 4 years ago by Ryan J Ollos

Priority: highnormal

comment:9 Changed 4 years ago by Ryan J Ollos

Status: assignednew

comment:10 Changed 2 years ago by Ryan J Ollos

Owner: Ryan J Ollos deleted

Modify Ticket

Change Properties
Set your email in Preferences
Action
as new The ticket will remain with no owner.

Add Comment


E-mail address and name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.