Modify

Opened 8 years ago

Closed 8 years ago

Last modified 8 years ago

#6756 closed defect (invalid)

ccselector tries to create a new ccbutton even if one is already present

Reported by: rkimball@… Owned by: Vladislav Naumov
Priority: normal Component: CcSelectorPlugin
Severity: normal Keywords:
Cc: Trac Release: 0.11

Description

ccselector tries to create a new ccbutton, even if one is already present. This can happen if the user reloads the page, or navigates away and then back.

When that happens, it causes which Action radio button is selected to change. If the user doesn't notice, the ticket can be paused unintentionally.

Patch attached. It simply looks for the ccbutton by id, and doesn't create it if it's already there.

Attachments (1)

ccselector_ccb.patch (1.8 KB) - added by rkimball@… 8 years ago.

Download all attachments as: .zip

Change History (3)

Changed 8 years ago by rkimball@…

Attachment: ccselector_ccb.patch added

comment:1 Changed 8 years ago by rkimball@…

Resolution: invalid
Status: newclosed

I've tested my patch more carefully, and realized that my report is incorrect. ccselector does not create a duplicate ccbutton - it only appeared that way because I had saved the page in my browser, and it saved the modified HTML rather than the original HTML.

Nonetheless, the behavior of the selected Admin radio button changing on reload is definitely related to ccselector. I'm closing this ticket as invalid, and I'll create a new one specifically for that issue.

comment:2 Changed 8 years ago by anonymous

Last update - the behavior with the selected Admin radio button only happens in Firefox, not in Chrome or IE8. So, it's probably a bug in Firefox that happens to be exposed by ccselector, so I'm not going to create a new ticket here after all.

Modify Ticket

Change Properties
Set your email in Preferences
Action
as closed The owner will remain Vladislav Naumov.
The resolution will be deleted.

Add Comment


E-mail address and name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.