Plugin uses "assert" to check perms, which could go away with -O

[Joshua Kugler]

On line 55 of web_ui.py (current svn), it says:

assert req.perm.has_permission('TICKET_ADMIN')

According to the Python docs, if a module is compiled with -O (or -OO), assert statements are discarded. See ​http://docs.python.org/reference/simple_stmts.html#the-assert-statement

Thus, if TicketChangePlugin is compiled with -O, there will be no permissions check in process_request(). While the buttons will not be displayed unless the TICKET_ADMIN permission exists, someone could do a direct post to the URL for editing the ticket.

[Ryan J Ollos]

Yes, this is an incorrect use of the Trac API.

[Ryan J Ollos]

(In [9653]) Fixed incorrect use of Trac API in enforcement of permissions. Fixes #6771.