Change announcement fails for wiki pages with non-ascii names

[o.shirochenkov@…]

AnnouncerPlugin (latest trunk 7719) fails while sending e-mail notification when the Wiki name is non-Ascii:

2010-03-12 20:42:02,560 Trac[api] ERROR: AnnouncementSystem failed.
Traceback (most recent call last):
  File "build/bdist.linux-i686/egg/announcer/api.py", line 382, in _real_send
    distributor.distribute(transport, packages[transport], evt)
  File "build/bdist.linux-i686/egg/announcer/distributors/mail.py", line 256, in distribute
    self._do_send(transport, event, k, v, fmtdict[k])
  File "build/bdist.linux-i686/egg/announcer/distributors/mail.py", line 380, in _do_send
    decorator.decorate_message(event, rootMessage, decorators)
  File "build/bdist.linux-i686/egg/announcer/email_decorators/wiki.py", line 67, in decorate_message
    return next_decorator(event, message, decorates)
  File "build/bdist.linux-i686/egg/announcer/util/mail.py", line 46, in next_decorator
    return next.decorate_message(event, message, decorates)
  File "build/bdist.linux-i686/egg/announcer/email_decorators/ticket.py", line 83, in decorate_message
    return next_decorator(event, message, decorates)
  File "build/bdist.linux-i686/egg/announcer/util/mail.py", line 46, in next_decorator
    return next.decorate_message(event, message, decorates)
  File "build/bdist.linux-i686/egg/announcer/email_decorators/ticket.py", line 71, in decorate_message
    return next_decorator(event, message, decorates)
  File "build/bdist.linux-i686/egg/announcer/util/mail.py", line 46, in next_decorator
    return next.decorate_message(event, message, decorates)
  File "build/bdist.linux-i686/egg/announcer/email_decorators/generic.py", line 137, in decorate_message
    return next_decorator(event, message, decorators)
  File "build/bdist.linux-i686/egg/announcer/util/mail.py", line 46, in next_decorator
    return next.decorate_message(event, message, decorates)
  File "build/bdist.linux-i686/egg/announcer/email_decorators/generic.py", line 116, in decorate_message
    return next_decorator(event, message, decorates)
  File "build/bdist.linux-i686/egg/announcer/util/mail.py", line 46, in next_decorator
    return next.decorate_message(event, message, decorates)
  File "build/bdist.linux-i686/egg/announcer/email_decorators/generic.py", line 64, in decorate_message
    uid = uid_encode(self.env.abs_href(), event.realm, event.target)
  File "build/bdist.linux-i686/egg/announcer/util/mail.py", line 73, in uid_encode
    return b32encode(uid)
  File "/usr/lib/python2.5/base64.py", line 152, in b32encode
    c1, c2, c3 = struct.unpack('!HHB', s[i*5:(i+1)*5])
  File "/usr/lib/python2.5/struct.py", line 87, in unpack
    return o.unpack(s)
error: unpack requires a string argument of length 5

[Steffen Hoffmann]

Since 0.12 wasn't out at the time of your report, could you confirm that this still applies to Trac 0.12, please?

May I further ask for some more details about your test environment? With "Wiki name" you refer to the wiki page name, and you certainly expected a page content change announcement to happen here, right? It could help to tell us the relevant page name etc. as well. Thanks in advance.

[o.shirochenkov@…]

Sorry, I can't check this with 0.12 because my installation of trac is bleeding-edge. I'll attach my configuration file and the latest and full log. The wiki page name is "ТестоваяСтраница".

About Trac

System Information

Trac	0.13dev-r9983
Trac	0.13dev-r9983
Babel	1.0dev-r488
Docutils	0.5
Genshi	0.6
mod_python	3.3.1
Pygments	1.2.2
pysqlite	2.4.1
Python	2.5.2 (r252:60911, Jan 24 2010, 15:24:24) [GCC 4.3.2]
Python	2.5.2 (r252:60911, Jan 24 2010, 15:24:24) [GCC 4.3.2]
pytz	2008c
pytz	2008c
setuptools	0.6c11
setuptools	0.6c11
SQLite	3.5.9
Subversion	1.5.1 (r32289)
jQuery:	1.4.2

Installed Plugins

AnnouncerPlugin	0.12-p2.dev	/usr/lib/python2.5/site-packages/AnnouncerPlugin-0.12_p2.dev-py2.5.egg
TracFlashEmbedMacro	N/A	/usr/share/trac/projects/os/trac/plugins/TracFlashEmbedMacro.pyc
UserStats	Rev	/usr/share/trac/projects/os/trac/plugins/UserStats.pyc

[o.shirochenkov@…]

log trac 0.13dev-r9983 and AnnouncerPlugin r8340

[o.shirochenkov@…]

my config trac 0.13dev-r9983

[o.shirochenkov@…]

Sorry, AnnouncerPlugin revision is r8336: Path: announcer URL: ​http://trac-hacks.org/svn/announcerplugin/trunk Repository Root: ​http://trac-hacks.org/svn Repository UUID: 7322e99d-02ea-0310-aa39-e9a107903beb Revision: 8340 Node Kind: directory Schedule: normal Last Changed Author: hasienda Last Changed Rev: 8336 Last Changed Date: 2010-08-05 16:05:49 +0400

[Steffen Hoffmann]

ТестоваяСтраница - nice (I remember a little from the 5 years of Russian lessons at school.) Thanks for the requested information. Now there is definitely something to start working on.

I'll try to find a solution. I suspect it might be related to (missing) unicode string encoding, and if so, this could be fixed easily. I hope so, let's do some debugging here and see.

[Steffen Hoffmann]

BTW, this is somewhat related to #6443.

[Robert Corsaro]

(In [8960]) Handle utf8 in subjects

Fixes #6799

[anonymous]

svn info Path: . URL: ​http://trac-hacks.org/svn/announcerplugin/trunk Repository Root: ​http://trac-hacks.org/svn Repository UUID: 7322e99d-02ea-0310-aa39-e9a107903beb Revision: 8968 Node Kind: directory Schedule: normal Last Changed Author: doki_pen Last Changed Rev: 8960 Last Changed Date: 2010-09-18 21:24:17 +0400 (Сбт, 18 Сен 2010)

Trac 0.13dev-r10103

TracAnnouncer 0.12.1.dev /usr/lib/python2.5/site-packages/TracAnnouncer-0.12.1.dev-py2.5.egg

Please tell me, is it just me or something is wrong? I'll attach a log.

[o.shirochenkov@…]

log trac 0.13dev-r10103 and TracAnnouncer r8960

[anonymous]

Ah. for me exception is gone, and email is sent, but title is blank. I'll look at it more. It's better ;)

[Robert Corsaro]

try it now

[o.shirochenkov@…]

r8969 doesn't work for me

[o.shirochenkov@…]

log trac 0.13dev-r10103 and TracAnnouncer r8969

[Robert Corsaro]

I can see the issue now. I add a reversible message id to the email so that trac can handle responses to emails. (this requires other tools as well, if interested, check out tracgate at ​http://github.com/dokipen). The trick to this message id is that, on a response email, I must be able to decode it to an actual resource so the response email can perform some action on the resource. This is only used for realms specified in

[announcer]
email_threaded_realms = wiki, ticket

As a workaround, you can change this to tickets. For tickets, the ticket id is used so you wont see this issue. Unfortunately, wiki name is the id for wiki pages. I'll get this fixed though.

[Robert Corsaro]

So this is workaround:

[announcer]
email_threaded_realms = ticket

[o.shirochenkov@…]

Our group don't really need "reply" feature, so this workaround fits us. I have changed my config and it works with non-ascii-named wiki pages. I can't even test tracgate feature at this time, so I don't know how can I help you to test further fixes for this ticket.

[o.shirochenkov@…]

Thank you, r8976 solved this issue!

[Robert Corsaro]

I should also mention that using the work around would stop your email client from being able to thread announcements about the same wiki page. I had forgotten this detail. But the workaround shouldn't be needed anymore.