Modify

Opened 8 years ago

Closed 4 months ago

#6917 closed defect (fixed)

Tabs and regular spaces? Really?

Reported by: Adam Bellaire Owned by: Ryan J Ollos
Priority: low Component: GoogleChartPlugin
Severity: minor Keywords:
Cc: Trac Release: 0.11

Description

The source code mixes tabs and spaces in charting.py. Specifically, the indentation level appears to be 4 spaces, but where the indentation is at least a multiple of 8, tabs are used first, and then spaces to do a "half-tab". This mixing is horrible on others trying to read and patch your code, or at least it was for me. Please switch to either all tabs or all spaces.

See PEP 8 -- Style Guide for Python Code, specifically the following:

Tabs or Spaces?

Never mix tabs and spaces.

Attachments (0)

Change History (3)

comment:1 Changed 8 years ago by Martin Aspeli

I no longer maintain this plugin. It's open source, though, do with what you wish.

comment:2 Changed 4 months ago by Ryan J Ollos

Owner: changed from Martin Aspeli to Ryan J Ollos
Status: newaccepted

comment:3 Changed 4 months ago by Ryan J Ollos

Resolution: fixed
Status: acceptedclosed

In 16727:

gchartplugin 0.2: Fix indentation

Fixes #6917.

Modify Ticket

Change Properties
Set your email in Preferences
Action
as closed The owner will remain Ryan J Ollos.
The resolution will be deleted.

Add Comment


E-mail address and name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.