Opened 7 years ago

Closed 4 years ago

NeverNotifyUpdaterPlugin in multiple trac environments.

Reported by: Owned by: nwheeler bobbysmith007 high NeverNotifyUpdaterPlugin major dave@… 0.11

Description

Hello!

I've got an environment (using mod_python) with multiple trac instances. It would seem that installing this plugin system wide forces this plugin to be used by *ALL* projects, once the-project-that-has-it-enabled's URL is hit...ie:

if self.compmgr.enabled[self.__class__]:)


Also, it seems this is the case even if the plugin is installed in the plugins/ directory. Specifically stating that the plugin is "disabled" in trac.ini has no affect. On the 'affected' project (of which I do NOT want this plugin to work in), if it's disabled it doesn't run the above code...but once the project with it enabled is hit, trac loads it, and then all projects are affected by it.

Can someone else confirm this behavior? I only want to NeverNotifyUpdater's on one project, and this doesn't seem to be possible, so I'm considering it a bug.

If you need any more information, I'd be willing to provide it.

comment:1 Changed 7 years ago by bobbysmith007

• Resolution set to fixed
• Status changed from new to closed

(In [7938]) Attempt to make nevernotify handle being enabled only for some trac instances rather than all or none. version 0.0.7 - fixes #7100

comment:3 Changed 4 years ago by dave@…

• Cc dave@… added; anonymous removed
• Resolution fixed deleted
• Status changed from closed to reopened

This problem seems to be happening again, with Trac 1.0.1 and NeverNotifyUpdaterPlugin 0.1.4 (0.13 branch, which is what the wiki page links to for Trac 1.0... seems like version on the 1.0 branch is older?)

As far as I can tell, I'm having the exact same problem as reported in this ticket... NeverNotifyUpdaterPlugin is installed system-wide on a system with two Trac instances. It's marked as disabled in one instance's trac.ini, and is actually disabled when Apache first starts. But when someone accesses the instance where the plugin is enabled, it gets enabled in the instance where it's supposed to be disabled. According to the DEBUG log, is_enabled() seems to be True. (The log shows the "NeverNotifyUpdaterPlugin: START tkt:" message).

comment:4 Changed 4 years ago by bobbysmith007

Thanks for the bug report... I will look into this and also try to resolve the 0.13/1.0 disparity

comment:5 follow-up: ↓ 7 Changed 4 years ago by bobbysmith007

Not sure what you were seeing, but the 0.13 branch and the 1.0 branch are currently identical (as I have made no changes since that branching). However, all changes for trac 1.0 (including this) will be going into the the 1.0 branch.

comment:6 Changed 4 years ago by bobbysmith007

• Resolution set to fixed
• Status changed from reopened to closed

(In [12967]) got disabling/enabling per project working again fix #7100

comment:7 in reply to: ↑ 5 Changed 4 years ago by anonymous

Not sure what you were seeing, but the 0.13 branch and the 1.0 branch are currently identical (as I have made no changes since that branching).

I didn't really look at the code; I was just seeing the version number in setup.py--in the 0.13 branch, it was 0.1.4, vs. 0.0.9 in the 1.0 branch. Should the "For Trac 1.0" links on the NeverNotifyUpdaterPlugin page be updated to point to 1.0?

Also, there's a typo in the new log message: "locally enbabled"

Thanks for the fix; I'll install the new version this evening and try it out :)

comment:8 Changed 4 years ago by bobbysmith007

Awesome catches, thank you! I have fixed the log message and wiki page

comment:9 Changed 4 years ago by dave@…

The new version works for me; thanks again! :)