Opened 14 years ago
Closed 5 years ago
#7174 closed enhancement (wontfix)
[PATCH] Properly register all configuration options so IniAdmin can edit them
Reported by: | Matthijs Kooijman | Owned by: | obs |
---|---|---|---|
Priority: | normal | Component: | BlackMagicTicketTweaksPlugin |
Severity: | normal | Keywords: | patch |
Cc: | Trac Release: | 0.11 |
Description
The plugin currently only registers a few options through the Option class. Others are requested using self.config.get
directly, since these have dynamic names, based on the value of the tweaks
configuration value.
The attached patch fixes this by registering all options, even those with dynamic names. The motivation to do this, is so that the IniAdminPlugin can then find the options and allows you to change them through the web interface.
Furthermore, I've changed the default values of most options to ''
instead of None
, since the Option class didn't seem to work with None. However, looking at #7124 suggests that it didn't work before either, so this patch probably fixes #7124 as well.
I've also documented all registered options, including the existing ones.
Attachments (1)
Change History (4)
comment:1 Changed 14 years ago by
Changed 14 years ago by
Attachment: | bmtt-configuration.diff added |
---|
Updated patch against 0.11 version, r8017
comment:2 Changed 14 years ago by
I've updated the patch, fixing an occurence of ''
where []
was required.
comment:3 Changed 5 years ago by
Resolution: | → wontfix |
---|---|
Status: | new → closed |
This plugin is deprecated in Trac 1.4 and later. See migration tips on BlackMagicTicketTweaksPlugin page.
Ah, one more thing. I've tested the entire thing, except for the stuff in IPermissionPolicy, since
check_permission
didn't seem to get called at all for me (but also not with a clean trunk, so this is probably another bug...).