Opened 6 years ago

Closed 2 years ago

Last modified 2 years ago

#7269 closed enhancement (wontfix)

Does not warn when closing Blocked tickets (set by MasterTicketsPlugin)

Reported by: dnedelchev Owned by: CuriousCurmudgeon
Priority: normal Component: BatchModifyPlugin
Severity: normal Keywords:
Cc: Trac Release: 0.11


There is no warning message when closing Blocked tickets when BatchModifyPlugin is used along with MasterTicketsPlugin. Note: Trac 0.11.7

Normally MasterTicketsPlugin doesn't allow closing blocked tickets from the standard single-tcket-modify interface at all.

For me it's OK to allow batch closing blocked tickets, but there should be at least an warning and/or an explicit confirmation requirement.
Maybe "warn_if_closing_blocked_tickets" and/or "require_confirmation_when_closing_blocked_tickets" admin-options could be useful too.

Attachments (0)

Change History (4)

comment:1 Changed 6 years ago by CuriousCurmudgeon

  • Type changed from defect to enhancement

I hesitate to add handling for interactions with specific plugins. There has been discussion about moving this plugin into the Trac core and then the MasterTicketsPlugin could be aware of batch modifications. That seems like the better solution. I'm going to keep this ticket open though to see if anybody else has thoughts.

comment:2 Changed 5 years ago by doug

MasterTicketsPlugin implements ITicketManipulator, and BatchModifyPlugin should call validate_ticket on all ticket manipulators. #T10125 discusses this issue for another plugin, and comment 17 there has a suggested implementation.

comment:3 Changed 2 years ago by rjollos

  • Resolution set to wontfix
  • Status changed from new to closed

The plugin is deprecated since it has been integrated to the Trac core for 1.0. Upgrade to Trac 1.0 and uninstall this plugin to get the latest functionality. Enhancement requests can be directed to Trac.

comment:4 Changed 2 years ago by rjollos

It might be fixed in trac:#11723.

Add Comment

Modify Ticket

as closed The owner will remain CuriousCurmudgeon.
The resolution will be deleted. Next status will be 'reopened'.

E-mail address and user name can be saved in the Preferences.

Note: See TracTickets for help on using tickets.