#7397 closed enhancement (fixed)
[Patch] Restrict view of developer page by adding a permission
| Reported by: | Steven R. Loomis | Owned by: | anonymous |
|---|---|---|---|
| Priority: | normal | Component: | TracDeveloperPlugin |
| Severity: | normal | Keywords: | |
| Cc: | Steffen Hoffmann | Trac Release: | 0.12 |
Description
patch to add a DEVELOPER_VIEW permission.
The reason is, 'Developer Tools' is confusing to users, as it has nothing to do with our site. So I hide it from non-admins.
Attachments (1)
Change History (15)
Changed 14 years ago by
| Attachment: | developer.patch added |
|---|
comment:1 Changed 14 years ago by
| Summary: | Restrict view of developer page with permission → [Patch] Restrict view of developer page by adding a permission |
|---|
comment:2 Changed 14 years ago by
This patch does not seem like it is all that useful since one typically (and good practice probably suggests never) develops on a production Trac instance that others have access to. Can you suggest another use case for this that I might not be thinking of?
comment:3 Changed 14 years ago by
| Owner: | changed from Michael Renzmann to osimons |
|---|
comment:4 Changed 14 years ago by
I don't primarily develop on a production trac server, however, these tools are useful for problem resolution at times.
At the least, it would help one create more realistic screen shots.
comment:6 Changed 13 years ago by
debugger.py:post_process_request also requires a DEVELOPER_VIEW permissions check for if 'debug' not in req.args
comment:7 Changed 13 years ago by
| Cc: | Steffen Hoffmann added; anonymous removed |
|---|
The patch looks good to me. If an experienced Trac developer can sign off on it, I'd be happy to push it to the repository.
comment:8 follow-up: 9 Changed 13 years ago by
While generally I support your position, I see Steven's point too.
Can't harm to have this in, but in addition to Leho's comment you should ensure that the output of get_permission_actions is always a list, or the list of permissions could get messed up badly. I think I saw this happen when tampering with adding permissions to another plugin on my own: I got multiple single-char permissions instead of one.
comment:9 Changed 13 years ago by
Replying to hasienda:
Can't harm to have this in, ...
That was my thought too after reading the discussion that followed. I'm fairly sure this plugin is currently un-maintained. I think I reassigned this ticket to Osimons early on thinking he was maintaining it, but had a discussion with him later and he said that's not the case.
I'll leave this for a few days to see if anyone has comments about the maintenance status.
comment:11 Changed 12 years ago by
| Owner: | changed from osimons to Olemis Lang |
|---|
comment:12 Changed 11 years ago by
| Owner: | changed from Olemis Lang to anonymous |
|---|---|
| Status: | new → assigned |
comment:14 Changed 11 years ago by
DEVELOP as an action name seems a bit inconsistent with the naming conventions of the other action names. What about TRAC_DEVELOP?
the patch (forgot I had a login at create)