Modify

Opened 7 years ago

Closed 12 months ago

Last modified 12 months ago

#7428 closed defect (fixed)

[Patch] Ticket sidebar takes up half the screen width with Trac 0.12

Reported by: Dennis McRitchie <dmcr@…> Owned by: Steffen Hoffmann
Priority: normal Component: TicketSidebarProviderPlugin
Severity: normal Keywords: misplacement CSS
Cc: Trac Release: 0.12

Description

As mentioned above, when the ticket sidebar is enabled, it takes up half the width of the screen instead of just a small portion. It does this whether there is anything to display in the sidebar area.

I have a couple of patches to: 1) Keep the ticket display centered and normal in size when there is no sidebar info to display; and 2) Simply move the ticket display to the left (but keep its normal size) when displaying sidebar info, whose size defaults to 20% of the content area.

Dennis

Attachments (2)

ticketsidebar.py.patch (653 bytes) - added by Dennis McRitchie <dmcr@…> 7 years ago.
Fix to only apply sidebar style sheet when there is sidebar content to display
ticket-sidebar.css.patch (548 bytes) - added by Dennis McRitchie <dmcr@…> 7 years ago.
Sidebar style sheet to move ticket to the left, and default sidebar size to 20% of content area

Download all attachments as: .zip

Change History (9)

Changed 7 years ago by Dennis McRitchie <dmcr@…>

Attachment: ticketsidebar.py.patch added

Fix to only apply sidebar style sheet when there is sidebar content to display

Changed 7 years ago by Dennis McRitchie <dmcr@…>

Attachment: ticket-sidebar.css.patch added

Sidebar style sheet to move ticket to the left, and default sidebar size to 20% of content area

comment:1 Changed 7 years ago by Ryan J Ollos

Summary: Ticket sidebar takes up half the screen width with Trac 0.12[Patch] Ticket sidebar takes up half the screen width with Trac 0.12

comment:2 Changed 5 years ago by Steffen Hoffmann

(In [11697]) TicketSidebarProviderPlugin: Non-maintainer change applying old patch, refs #7428.

As proposed by Dennis McRitchie, CSS definitions for this plugin should only be added if required (ticketsidebar.py.patch).

I couldn't detect a positive effect from this change alone, but no negative side-effects either, so this is more an excuse for a small code clean-up; tested with Trac 0.13-r10880.

comment:3 Changed 5 years ago by Steffen Hoffmann

(In [11698]) TicketSidebarProviderPlugin: Another non-maintainer commit to fix display issues, refs #7428.

CSS changes, that have a positive effect indeed, are applied here.

Thanks again to Dennis McRitchie, who suggested these changes a long time ago; tested with trac 0.13dev-t:r10880 as well.

comment:4 Changed 5 years ago by Steffen Hoffmann

Keywords: misplacement CSS added

Comments welcome, if this ticket should be closed now.

Please see probably related issues, like #8785, as well.

comment:5 Changed 3 years ago by Ryan J Ollos

Owner: Jeff Hammel deleted

comment:6 Changed 12 months ago by Ryan J Ollos

Resolution: fixed
Status: newclosed

comment:7 Changed 12 months ago by Ryan J Ollos

Owner: set to Steffen Hoffmann

Modify Ticket

Change Properties
Set your email in Preferences
Action
as closed The owner will remain Steffen Hoffmann.
The resolution will be deleted.

Add Comment


E-mail address and name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.