Modify

Opened 7 years ago

Closed 3 years ago

Last modified 3 years ago

#7455 closed enhancement (fixed)

Add entries for scripts in theme info

Reported by: Olemis Lang Owned by: Olemis Lang
Priority: high Component: ThemeEnginePlugin
Severity: normal Keywords: script javascript theme
Cc: Trac Release: 0.11

Description

Currently it's quite easy to override CSS rules in a theme , but (AFAIK) there's no easy way to include scripts. IOW , it's necessary to re-implement IRequestFilter interface and call add_script in order to get theme-specific scripts added.

It would be nice to be able to list script files (i.e. path + script type) so that ThemeEnginePlugin will add these files auto-magically . I mean, it's such a common and simple use case ...

Attachments (0)

Change History (6)

comment:1 Changed 3 years ago by Olemis Lang

Owner: changed from Noah Kantrowitz to Olemis Lang

comment:2 Changed 3 years ago by Olemis Lang

Resolution: fixed
Status: newclosed

In 13523:

ThemeEnginePlugin [ fixes #7455 ]: Declare custom theme scripts via 'scripts' member in theme info

  • Docs updated
  • Supported in themeengine.api.ThemeBase

comment:3 Changed 3 years ago by Ryan J Ollos

The version of the plugin remains 2.2.2 throughout recent changes, [13506:13523/themeengineplugin]. It would be useful to add a setup.cfg to the trunk and mark the current configuration as dev.

Last edited 3 years ago by Ryan J Ollos (previous) (diff)

comment:4 in reply to:  3 Changed 3 years ago by Olemis Lang

Replying to rjollos:

The version of the plugin remains 2.2.2 throughout recent changes,

That's the target version I'm developing

It would be useful to add a setup.cfg to the trunk and mark the current configuration as dev.

definitely sure ... ;)

comment:5 Changed 3 years ago by Olemis Lang

In 13531:

TracDeveloper [ refs #7455 ]: Add setup.cfg file status=dev

comment:6 Changed 3 years ago by Olemis Lang

In 13532:

ThemeEnginePlugin [ refs #7455 ]: Add setup.cfg file status=dev

Modify Ticket

Change Properties
Set your email in Preferences
Action
as closed The owner will remain Olemis Lang.
The resolution will be deleted. Next status will be 'reopened'.

Add Comment


E-mail address and name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.