Opened 14 years ago
Closed 14 years ago
#7514 closed defect (fixed)
Reformatting misses edited ticket comments
| Reported by: | dnedelchev | Owned by: | Mikael Relbe |
|---|---|---|---|
| Priority: | normal | Component: | TracTicketChangesetsPlugin |
| Severity: | normal | Keywords: | edit reformat |
| Cc: | Trac Release: | 0.12 |
Description (last modified by )
I found that tracopt-stile macros are neither listed by diff command nor updated by reformat command for edited comments. While other untouched comments in the same message (containing tracopt-stile macros too) are processed as expected.
That can be seen on the screenshot I'm attaching: Comment 2 (concerning Revision 100) was edited manually before reformatting and Comment 3 (concerning Revision 101) was not. Comment 3 is upgraded and Comment 2 is not. Hence the error message is raised when tracopt/CommitTicketReferenceMacro is disabled.
Attachments (1)
Change History (5)
Changed 14 years ago by
| Attachment: | reformatting_edited_comment.png added |
|---|
comment:3 Changed 14 years ago by
comment:4 Changed 14 years ago by
| Description: | modified (diff) |
|---|---|
| Summary: | reformatting misses edited ticket comments → Reformatting misses edited ticket comments |
comment:5 Changed 14 years ago by
| Status: | new → assigned |
|---|
This observation is probably correct -- I forgot to implement a conversion for "0.12-style comments" since I myself went from Trac 0.11 to 0.12 in connection to applying this plugin for all of my databases.
Thanks for finding this.
comment:4 Changed 14 years ago by
| Resolution: | → fixed |
|---|---|
| Status: | assigned → closed |
(In [10001]) Fixed #7514: Reformatting misses edited ticket comments
The problem is even worse: historical content of ticket comments is destroyed in the database and makes Trac crash... (concerns Trac 0.12 which allows editing of ticket comments).
This is now fixed.
(I'm so sorry for the ridiculous long delay in fixing this.)
#7513 is a duplicate. I'll leave this ticket open since it has additional info.