Modify

Opened 11 years ago

Closed 11 years ago

Last modified 10 years ago

#753 closed defect (fixed)

Wrong comment deletion

Reported by: Emmanuel Blot Owned by: Noah Kantrowitz
Priority: normal Component: TicketDeletePlugin
Severity: major Keywords:
Cc: Trac Release: 0.10

Description

In t:ticket:295, when the spam comment is selected for deletion, the wrong comment is selected in the admin page. See comment #17.

Attachments (0)

Change History (3)

comment:1 Changed 11 years ago by Emmanuel Blot

Tested w/ Firefox 2.0 RC1 and Safari 2.0.4 (419.3)

comment:2 Changed 11 years ago by Emmanuel Blot

Trac Release: 0.90.10

Ok, I think I understand what's going wrong, as the problem also shows up with other tickets:

Attaching a file create a ticket event in Trac. However, a new attachment is not accounted as a comment, so the comment numbering in Trac skips all attachment events.

The trouble is that the TicketDeletePlugin does not follow the same rule, it counts attachment events as regular comment events, hence the error: each file attached to a ticket produces an offset for TicketDeletePlugin.

Hope this helps.

comment:3 Changed 11 years ago by Noah Kantrowitz

Resolution: fixed
Status: newclosed

(In [1378]) Don't show attachment "changes" in the delete screen. Fixes #753.

Modify Ticket

Change Properties
Set your email in Preferences
Action
as closed The owner will remain Noah Kantrowitz.
The resolution will be deleted. Next status will be 'reopened'.

Add Comment


E-mail address and name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.