Modify

Opened 7 years ago

Closed 7 years ago

Last modified 7 years ago

#7581 closed defect (fixed)

Add a 0.12 compatible version

Reported by: Rainer Sokoll Owned by: Ryan J Ollos
Priority: normal Component: FullBlogNotificationPlugin
Severity: normal Keywords: 0.12-compatible
Cc: Trac Release: 0.12

Description

Hi,

are there plans to make this plugin compatible to 0.12 trac? ATM, it raises an error:

'FullBlogNotificationEmail' object has no attribute 'smtp_server'.

Attachments (0)

Change History (10)

comment:1 Changed 7 years ago by Ryan J Ollos

Status: newassigned

Yes. Setting up dev environment to test.

comment:2 Changed 7 years ago by Ryan J Ollos

I have it working now under 0.12, but I need to fixup the template because the emails look ugly. I'll have a 0.12 version posted by this evening.

comment:3 Changed 7 years ago by Ryan J Ollos

(In [8539]) Creating a 0.12 branch. Refs #7581.

comment:4 Changed 7 years ago by Ryan J Ollos

I'm making some modifications to the template and opened an enhancement request for the FullBlogPlugin in the process: #7593. It would be nice if a comment could exist in the emails that are sent on deletion of a blog post or post version.

comment:5 Changed 7 years ago by Ryan J Ollos

Opened ticket #7595 with some suggested cleanup work that was discovered while working on this ticket.

comment:6 Changed 7 years ago by Ryan J Ollos

Noticed that all datetimes are in UTC and opened ticket #7596, which I hope to tackle within the next few days.

comment:7 Changed 7 years ago by Ryan J Ollos

(In [8564]) Updated the email template for Trac 0.12. Trac 0.12 uses Genshi 0.6, which has a new text template syntax (1). Trac's default template (ticket_notify_email.txt) was updated in 8999 for the new Genshi syntax (2). That changeset was used as a template for the changes made to the FullBlogNotificationPlugin's email template. The template was also changed so that the formatting more closely resemble's Trac's default template.

comment:8 Changed 7 years ago by Ryan J Ollos

Resolution: fixed
Status: assignedclosed

(In [8565]) 0.12 branch: Plugin is now compatible with 0.12. Replaced Genshi's TextTemplate with NewTextTemplate (1). Modifed send method to account for changes in the corresponding method in the Trac core which it was copied from and modified (2). Bumped version to 0.2 and added requirements for Trac >= 0.12 and Genshi >= 0.6 on this branch. Fixes #7581.

comment:9 Changed 7 years ago by Ryan J Ollos

Keywords: 0.12-compatible added
Summary: 0.12 compatible version?Add a 0.12 compatible version

comment:10 Changed 7 years ago by Ryan J Ollos

(In [8581]) 0.11 branch: Replicated changes made to new Genshi template in 0.12 branch in [8564] and [8565]. Refs #7581.

Modify Ticket

Change Properties
Set your email in Preferences
Action
as closed The owner will remain Ryan J Ollos.
The resolution will be deleted.

Add Comment


E-mail address and name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.