Opened 7 years ago

Closed 7 years ago

API update in [8493] breaks old syntax

Description

Hi: After changeset [8493] the markers options like color are missing.

Now address and coordinates works fine together:

[[GoogleStaticMap(center="Providencia Santiago Chile",zoom=15,size=400x400,markers="Providencia Santiago Chile"|-33.432749:-70.615852)]]


But if I add optional argument like color, the markers doesn't show up:

[[GoogleStaticMap(center=-33.432749:-70.615852,zoom=15,size=400x400,markers=-33.432749:-70.615852:bluea)]]


The actual features are ok for me, but I think that would be helpful to report this issue.

Regards Javier

comment:1 Changed 7 years ago by Martin Scharrer

Priority: normal → high normal → critical new → assigned After changeset [8493] markers options are missing → API update in [8493] breaks old syntax

Thanks for reporting this.

Since [8493] the new API 2.0 of Google is used, which changes the markers syntax (and most likely other syntax as well). See http://code.google.com/apis/maps/documentation/staticmaps/#MarkerStyles for details.

I will have to add an api option to select between the old and new API version in order to allow to support old code.

comment:2 Changed 7 years ago by Martin Scharrer

Resolution: → fixed assigned → closed

(In [8557]) tracgooglestaticmap/macro.py:: Finished support for old (1) and new (2) Google Static Map API. This fixes #7591.

comment:3 in reply to:  description ; follow-up:  4 Changed 7 years ago by Martin Scharrer

[...] But if I add optional argument like color, the markers doesn't show up:

 [[[GoogleStaticMap(center=-33.432749:-70.615852,zoom=15,size=400x400,markers=-33.432749:-70.615852:bluea)]]


The actual features are ok for me, but I think that would be helpful to report this issue.

You can get this to work in the following way the new syntax:

[[GoogleStaticMap(center="-33.432749,-70.615852",zoom=15,size=400x400,markers="color:blue|label:A|-33.432749,-70.615852")]]


This gives you this image.

comment:4 in reply to:  3 ; follow-up:  5 Changed 7 years ago by tatadeluxe@…

[...] But if I add optional argument like color, the markers doesn't show up:

 [[GoogleStaticMap(center=-33.432749:-70.615852,zoom=15,size=400x400,markers=-33.432749:-70.615852:bluea)]]


The old syntax for markers doesn't work anymore, Backward compatibility is missing, but for me is not a problem.

The actual features are ok for me, but I think that would be helpful to report this issue.

You can get this to work in the following way the new syntax:

 [[GoogleStaticMap(center="-33.432749,-70.615852",zoom=15,size=400x400,markers="color:blue|label:A|-33.432749,-70.615852")]]


This gives you this image.

The new syntax works OK, :D

Regars Javier

comment:5 in reply to:  4 Changed 7 years ago by Martin Scharrer

The old syntax for markers doesn't work anymore, Backward compatibility is missing, but for me is not a problem.

Yes, I saw that. This is now fixed in [8571].

The new syntax works OK, :D

Thanks for verifying this.

Modify Ticket

Change Properties