Modify

Opened 7 years ago

Closed 4 years ago

#7621 closed defect (fixed)

graphviz errors ignored without logging

Reported by: Hal Owned by: Ryan J Ollos
Priority: normal Component: MasterTicketsPlugin
Severity: normal Keywords:
Cc: Trac Release: 0.11

Description

ticket:7415 shows a case where it was difficult to debug, as the error is silently ignored.

In this case, the error comes from execution of an external program (dot) via the subprocess.Popen.communicate method

It would be helpful to log, at DEBUG level:

  • return code (at least if non-zero)
  • stderr output

My personal preference would be for all other functionality of master ticket to continue to work, but raising an exception is also reasonable.

Attachments (1)

patch.diff (3.1 KB) - added by Hal 7 years ago.
Patch to add logging of dot command errors

Download all attachments as: .zip

Change History (5)

Changed 7 years ago by Hal

Attachment: patch.diff added

Patch to add logging of dot command errors

comment:1 Changed 4 years ago by Ryan J Ollos

Owner: changed from Noah Kantrowitz to Ryan J Ollos
Status: newassigned

Patch can be simplified a bit, but otherwise looks good.

comment:2 Changed 4 years ago by Ryan J Ollos

Example of error message:

08:44:06 PM Trac[graphviz] ERROR: dot dot failed with code 1: Format:
"png2" not recognized. Use one of: canon cmap cmapx cmapx_np dot eps fig
gd gd2 gif gv imap imap_np ismap jpe jpeg jpg pdf plain plain-ext png ps
ps2 svg svgz tk vml vmlz vrml wbmp x11 xdot xlib

comment:3 Changed 4 years ago by Ryan J Ollos

(In [12946]) Refs #7621: Log errors from calling GraphViz.

comment:4 Changed 4 years ago by Ryan J Ollos

Resolution: fixed
Status: assignedclosed

Modify Ticket

Change Properties
Set your email in Preferences
Action
as closed The owner will remain Ryan J Ollos.
The resolution will be deleted. Next status will be 'reopened'.

Add Comment


E-mail address and name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.