Modify ↓
Opened 14 years ago
Closed 12 years ago
#7621 closed defect (fixed)
graphviz errors ignored without logging
Reported by: | Hal | Owned by: | Ryan J Ollos |
---|---|---|---|
Priority: | normal | Component: | MasterTicketsPlugin |
Severity: | normal | Keywords: | |
Cc: | Trac Release: | 0.11 |
Description
ticket:7415 shows a case where it was difficult to debug, as the error is silently ignored.
In this case, the error comes from execution of an external program (dot
) via the subprocess.Popen.communicate
method
It would be helpful to log, at DEBUG level:
- return code (at least if non-zero)
- stderr output
My personal preference would be for all other functionality of master ticket to continue to work, but raising an exception is also reasonable.
Attachments (1)
Change History (5)
Changed 14 years ago by
Attachment: | patch.diff added |
---|
comment:1 Changed 12 years ago by
Owner: | changed from Noah Kantrowitz to Ryan J Ollos |
---|---|
Status: | new → assigned |
Patch can be simplified a bit, but otherwise looks good.
comment:2 Changed 12 years ago by
Example of error message:
08:44:06 PM Trac[graphviz] ERROR: dot dot failed with code 1: Format: "png2" not recognized. Use one of: canon cmap cmapx cmapx_np dot eps fig gd gd2 gif gv imap imap_np ismap jpe jpeg jpg pdf plain plain-ext png ps ps2 svg svgz tk vml vmlz vrml wbmp x11 xdot xlib
comment:4 Changed 12 years ago by
Resolution: | → fixed |
---|---|
Status: | assigned → closed |
Note: See
TracTickets for help on using
tickets.
Patch to add logging of
dot
command errors