Modify

Opened 6 years ago

Closed 6 years ago

Last modified 5 years ago

#7735 closed defect (fixed)

Latest change for MySQL "as rows" breaks the macro fo SQLITE

Reported by: markm Owned by: Ryan J Ollos
Priority: normal Component: WikiSearchMacro
Severity: normal Keywords:
Cc: mark.m.mcmahon@… Trac Release: 0.11

Description

I was getting an error saying that the DB was locked.

When I remove the 'as rows' change that was implemented in the latest change committed it worked again.

Note - I also noticed a mix of tabs and spaces in the file.

Attachments (1)

UndoAsRows_fix_tabs.patch (559 bytes) - added by markm 6 years ago.
Patch to fix for SQLITE (but maybe not work for Mysql?) and remove tabs

Download all attachments as: .zip

Change History (6)

Changed 6 years ago by markm

Attachment: UndoAsRows_fix_tabs.patch added

Patch to fix for SQLITE (but maybe not work for Mysql?) and remove tabs

comment:1 Changed 6 years ago by anonymous

Ahh - there is a better fix!!

It would seem that rows is a restricted/reserved word for Sqlite - if you change that to as TempTable then it still works for Sqlite - and hopefully works for MySQL also :)

Thanks

Mark

comment:2 Changed 6 years ago by Ryan J Ollos

Status: newassigned

Thanks for the patch. It will be tested and applied this evening.

comment:3 Changed 6 years ago by Ryan J Ollos

It seems to be happy with either as rows or as temptable in my test setup. However, I'll make the change since it seems at most harmless.

comment:4 Changed 6 years ago by Ryan J Ollos

Resolution: fixed
Status: assignedclosed

(In [9626])

  • Removed print statements.
  • Replaced rows with temptable in query because rows is a reserved work in SQLite. Fixes #7735.

comment:5 Changed 5 years ago by Ryan J Ollos

(In [11971]) Deleted .pydevproject file accidentally committed in [9626].

Modify Ticket

Change Properties
Set your email in Preferences
Action
as closed The owner will remain Ryan J Ollos.
The resolution will be deleted. Next status will be 'reopened'.

Add Comment


E-mail address and name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.