Modify

Opened 7 years ago

Closed 3 months ago

#7791 closed defect (wontfix)

[patch] charset="us-ascii" in text part of html announcement

Reported by: Dmitri Owned by:
Priority: normal Component: AnnouncerPlugin
Severity: trivial Keywords: charset
Cc: Jan Beilicke Trac Release: 0.12

Description

When I choose the 'text/html' announcement format the first part of multipart/alternative mime has Content-Type: text/plain; charset="us-ascii", but second - Content-Type: text/html; charset="utf-8"

[announcer]
mime_encoding = qp

Why? How can I change this behavior?

The message contains cyrillic characters. Then I choose multiple messages in Thunderbird, it displays something like Приоритет. MS Outlook displays such characters always.

Attachments (0)

Change History (10)

comment:1 Changed 7 years ago by Dmitri

Alternative part appears without charset setting:

  • distributors/mail.py

    old new  
    489489
    490490            alt_msg_format = 'html' in alternate_style and 'html' or 'plain'
    491491            msgText = MIMEText(alternate_output, alt_msg_format)
     492            msgText.set_charset(self._charset)
    492493            parentMessage.attach(msgText)
    493494        else:
    494495            parentMessage = rootMessage

comment:2 Changed 6 years ago by Dmitri

Severity: normaltrivial
Summary: charset="us-ascii" in text part of html announcement[patch] charset="us-ascii" in text part of html announcement

comment:3 Changed 6 years ago by Jan Beilicke

Cc: Jan Beilicke added; anonymous removed

comment:4 Changed 5 years ago by Steffen Hoffmann

(In [12341]) TracAnnouncer: Apply suitable charset to alternative part of email message as well, refs #7791.

This fixes inappropriate alternative text display of non-ascii characters in HTML emails, that get sent out as multi-part message in MIME format.

This has been reported by g1itch, who did investigations and patch as well. Works like a breeze, but this must have been much harder to fix than one would expect at first glance onto this one-liner. It's a pleasure to follow your footsteps, thanks a bunch.

comment:5 Changed 3 years ago by Dmitri

Resolution: worksforme
Status: newclosed

Still open?

comment:6 in reply to:  5 ; Changed 3 years ago by Steffen Hoffmann

Owner: changed from Robert Corsaro to Steffen Hoffmann

Replying to g1itch:

Still open?

Yeah, personal preference to keep tickets open for a while/next stable release, encouraging testers to report back as you did - thanks.

comment:7 in reply to:  6 Changed 3 years ago by Dmitri

Replying to hasienda:

Replying to g1itch:

Still open?

Yeah, personal preference to keep tickets open for a while/next stable release, encouraging testers to report back as you did - thanks.

My personal preference is to apply patch and forget. I found this while looking for #10974.

comment:8 Changed 3 years ago by Ryan J Ollos

Resolution: worksforme
Status: closedreopened

Worksforme would certainly not be the proper resolution, regardless. Please leave tickets for project maintainer to manage as they see fit.

Last edited 3 years ago by Ryan J Ollos (previous) (diff)

comment:9 Changed 7 months ago by Ryan J Ollos

Owner: Steffen Hoffmann deleted
Status: reopenednew

comment:10 Changed 3 months ago by Ryan J Ollos

Resolution: wontfix
Status: newclosed

Please upgrade to Trac 1.2, which has integrated the core of AnnouncerPlugin. Please raise the issue on the trac:MailingList if you encounter the issue with Trac 1.2.

Modify Ticket

Change Properties
Set your email in Preferences
Action
as closed The ticket will remain with no owner.
The resolution will be deleted.

Add Comment


E-mail address and name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.