Modify

Opened 11 years ago

Closed 10 years ago

#795 closed defect (fixed)

AddComment does not post, preview, or cancel.

Reported by: aaron@… Owned by: Alec Thomas
Priority: high Component: AddCommentMacro
Severity: normal Keywords:
Cc: Stephan.Wacker@…, blach@…, nicholas, Robert Kieffer Trac Release: 0.10

Description

When I click Add Comment, Preview, or Cancel, it attempts to load, e.g. /wiki/MyWikiPage#commentpreview and there is simply a "Create this page" button, nothing else.

I've just upgraded to 0.10.1dev; if it is a configuration issue, no such indications were given on the hack's description page.

Attachments (0)

Change History (14)

comment:1 Changed 10 years ago by jose.junior@…

Priority: normalhigh

Same behavior here using 0.10.

comment:2 Changed 10 years ago by Alec Thomas

Resolution: worksforme
Status: newclosed

Works for me using 0.10.3. This could have been an artifact of the CSRF protection.

comment:3 Changed 10 years ago by Harald Radi

Resolution: worksforme
Status: closedreopened

would have been nice but still doesn't work for me

see http://harald.fluffnstuff.org/wiki/test

comment:4 in reply to:  3 Changed 10 years ago by Noah Kantrowitz

Replying to harald:

would have been nice but still doesn't work for me

see http://harald.fluffnstuff.org/wiki/test

Did you modify the macro at all? It seems to be using POSTs where it should be using GETs.

comment:5 Changed 10 years ago by Harald Radi

egbert:/home/harald/trac-stuff/addcommentmacro/0.10# svn up At revision 1851. egbert:/home/harald/trac-stuff/addcommentmacro/0.10# svn status ? build ? TracAddCommentMacro.egg-info ? temp

therefore no :)

I'm running trac on an apache webserver using mod_python, could this somehow interfere?

comment:6 Changed 10 years ago by eric@…

Trac Release: 0.90.10

Yes, the code in svn (as of r1855) is using 'post' as the method.

Changing the method='post' to method='get' has solved the problem for me. (on 0.10.3)

comment:7 Changed 10 years ago by Harald Radi

Verified. Changing the method from post to get worked for me too.

comment:8 Changed 10 years ago by paul@…

Switching from post to get might fix the code, but it is definitely not an appropriate use of HTTP GET.

http://www.w3.org/2001/tag/doc/whenToUseGet.html

comment:9 in reply to:  8 Changed 10 years ago by eric@…

Replying to paul@prescod.net:

Switching from post to get might fix the code, but it is definitely not an appropriate use of HTTP GET.

Agreed. People can (and do) reload a page and double post a comment. Does anybody have a better fix yet? Thanks.

comment:10 Changed 10 years ago by anonymous

Cc: Stephan.Wacker@… added; anonymous removed

comment:11 Changed 10 years ago by anonymous

Cc: blach@… added

comment:12 Changed 10 years ago by anonymous

Cc: nicholas added

comment:13 Changed 10 years ago by anonymous

Cc: Robert Kieffer added

comment:14 Changed 10 years ago by Noah Kantrowitz

Resolution: fixed
Status: reopenedclosed

Please upgrade to the latest version. This should pull in the MacroPostPlugin, which will fix the issue.

Modify Ticket

Change Properties
Set your email in Preferences
Action
as closed The owner will remain Alec Thomas.
The resolution will be deleted. Next status will be 'reopened'.

Add Comment


E-mail address and name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.