Opened 11 years ago

Closed 10 years ago

AddComment does not post, preview, or cancel.

Reported by: Owned by: aaron@… Alec Thomas high AddCommentMacro normal Stephan.Wacker@…, blach@…, nicholas, Robert Kieffer 0.10

Description

When I click Add Comment, Preview, or Cancel, it attempts to load, e.g. /wiki/MyWikiPage#commentpreview and there is simply a "Create this page" button, nothing else.

I've just upgraded to 0.10.1dev; if it is a configuration issue, no such indications were given on the hack's description page.

comment:1 Changed 11 years ago by jose.junior@…

Priority: normal → high

Same behavior here using 0.10.

comment:2 Changed 11 years ago by Alec Thomas

Resolution: → worksforme new → closed

Works for me using 0.10.3. This could have been an artifact of the CSRF protection.

comment:3 follow-up:  4 Changed 11 years ago by Harald Radi

Resolution: worksforme closed → reopened

would have been nice but still doesn't work for me

comment:4 in reply to:  3 Changed 11 years ago by Noah Kantrowitz

would have been nice but still doesn't work for me

Did you modify the macro at all? It seems to be using POSTs where it should be using GETs.

comment:5 Changed 11 years ago by Harald Radi

therefore no :)

I'm running trac on an apache webserver using mod_python, could this somehow interfere?

comment:6 Changed 11 years ago by eric@…

Trac Release: 0.9 → 0.10

Yes, the code in svn (as of r1855) is using 'post' as the method.

Changing the method='post' to method='get' has solved the problem for me. (on 0.10.3)

comment:7 Changed 11 years ago by Harald Radi

Verified. Changing the method from post to get worked for me too.

comment:8 follow-up:  9 Changed 11 years ago by paul@…

Switching from post to get might fix the code, but it is definitely not an appropriate use of HTTP GET.

comment:9 in reply to:  8 Changed 10 years ago by eric@…

Switching from post to get might fix the code, but it is definitely not an appropriate use of HTTP GET.

comment:14 Changed 10 years ago by Noah Kantrowitz

Resolution: → fixed reopened → closed