#7976 closed defect (fixed)
filter_exception_realms is ignored in DefaultPermissionFilter
Reported by: | anonymous | Owned by: | Steffen Hoffmann |
---|---|---|---|
Priority: | normal | Component: | AnnouncerPlugin |
Severity: | major | Keywords: | acct_mgr permission |
Cc: | Ryan J Ollos, Robert Corsaro | Trac Release: | 0.12 |
Description
This makes it impossible for the acct_mgr plugin to ever work.
Attachments (0)
Change History (11)
comment:1 Changed 14 years ago by
comment:3 Changed 12 years ago by
Cc: | Ryan J Ollos Robert Corsaro added; anonymous removed |
---|---|
Keywords: | acct_mgr permission added |
Owner: | changed from Robert Corsaro to Steffen Hoffmann |
Priority: | highest → normal |
Severity: | critical → major |
comment:4 Changed 12 years ago by
(In [12309]) TracAnnouncer: Implement unused filter_exception_realms
option, refs #7976 and #7977.
The chosen implementation should be slightly more efficient than what has been proposed in #7976, but I agree, that this is a pre-reqisite for making some subscribers effective, i.e. AccountManagerPlugin notifications.
comment:5 Changed 12 years ago by
(In [12325]) TracAnnouncer: Fix generator, that was broken by [12309], refs #7759, #7976, #7977, #8740, #8927, #9090 and #9204.
And the same bad filter code even got replicated in [12312]. Sorry for not
checking compiler errors earlier. Finally I discovered an UnboundLocalError
for resource_id
hidden behind the first error. Obviously unit tests are
a blessing and needed here too.
comment:6 Changed 12 years ago by
comment:7 Changed 12 years ago by
(In [12342]) TracAnnouncer: Add 'acct_mgr' as default for 'filter_exception_realms' option, refs #7759, #7976, #7977, #8740, #8927, #9090 and #9204.
IMHO this is required for better plugin usability, making AccountManagerPlugin notifications pass without additional configuration effort now.
Some Python doc-string tweaks and another unit test slipped in here too.
comment:8 Changed 12 years ago by
comment:9 Changed 8 years ago by
Owner: | Steffen Hoffmann deleted |
---|
comment:10 Changed 8 years ago by
Resolution: | → fixed |
---|---|
Status: | new → closed |
comment:11 Changed 8 years ago by
Owner: | set to Steffen Hoffmann |
---|
Change
if permsys.check_permission(action, sid):
toif event.realm in self.exception_realms or permsys.check_permission(action, sid):
.