Modify ↓

Opened 18 years ago

Closed 18 years ago

#799 closed enhancement (fixed)

IniAdminPlugin is broken in trac 0.11

Reported by: PotatoSalad Owned by: Alec Thomas
Priority: lowest Component: IniAdminPlugin
Severity: trivial Keywords: 0.11 IniAdminPlugin Genshi PotatoSalad plugin
Cc: Trac Release: 0.10

Description

I upgraded to Python 2.5 the today and found out that trac 0.10 is incompatible with Python 2.5 (more specifically, ​ClearSilver). So, I upgraded to the trunk version of trac 0.11 to find out that all my of plugins went down the tubes (mostly because of the switch to ​Genshi from ​ClearSilver).

Anyway, here's my first patch to get IniAdminPlugin working with ​Genshi in trac 0.11.

Attachments (2)

iniadminplugin-genshi_trac-0.11dev.diff​ (6.0 KB) - added by PotatoSalad 18 years ago.
Patch to upgrade IniAdminPlugin to trac 0.11 with ​Genshi.
iniadminplugin-genshi_trac-0.11dev_2.diff​ (6.1 KB) - added by PotatoSalad 18 years ago.
Second patch to upgrade IniAdminPlugin to trac 0.11 with ​Genshi (a few CSS fixes).

Download all attachments as: .zip

Change History (11)

Changed 18 years ago by PotatoSalad

Attachment: iniadminplugin-genshi_trac-0.11dev.diff​ added

Patch to upgrade IniAdminPlugin to trac 0.11 with ​Genshi.

comment:1 Changed 18 years ago by PotatoSalad

Component: TracHacks → IniAdminPlugin

Whoops, change the component.

comment:2 Changed 18 years ago by Noah Kantrowitz

Unless Alec is feeling especially brave, I doubt many plugins will migrate to Genshi until they actually finalize all the interfaces. If you downgrade to Python 2.4, Trac has backwards compatibility systems so that ClearSilver-based plugins will continue to work.

Changed 18 years ago by PotatoSalad

Attachment: iniadminplugin-genshi_trac-0.11dev_2.diff​ added

Second patch to upgrade IniAdminPlugin to trac 0.11 with ​Genshi (a few CSS fixes).

comment:3 Changed 18 years ago by PotatoSalad

@coderanger: I realize that, but I wanted to mess around with Genshi and used this plugin as a test for porting to Genshi (mostly because of its simplicity). I'm using it right now, so I figured someone might find this helpful.

comment:4 Changed 18 years ago by anonymous

this doesnt seem to want to work with 0.11's WebAdmin built in...could you look into that too please?

comment:5 Changed 18 years ago by rupert thurner

we run trac 0.10-dev for a while now with python-2.5 so i'm not sure why you say there is a relationship python-version : clearsilver?

we have no running subversion connection though ... but this is my stupidity to compile this swig-GRMPF to make the python bindings work on solaris i guess.

comment:6 in reply to:  5 Changed 18 years ago by PotatoSalad

Replying to ThurnerRupert:

we run trac 0.10-dev for a while now with python-2.5 so i'm not sure why you say there is a relationship python-version : clearsilver?

we have no running subversion connection though ... but this is my stupidity to compile this swig-GRMPF to make the python bindings work on solaris i guess.

At the time I submitted this (October 12, 2006), clearsilver (version 0.10.3) would segfault when built with Python 2.5. The new version of clearsilver (version 0.10.4) works with Python 2.5, so I have happily been running trac 0.10.2 since. I really made this patch out of curiosity for Genshi and figured someone might find it useful.

comment:7 Changed 18 years ago by Alec Thomas

Priority: high → lowest
Severity: blocker → trivial

comment:8 Changed 18 years ago by Alec Thomas

Type: defect → enhancement

comment:9 Changed 18 years ago by Alec Thomas

Resolution: → fixed
Status: new → closed

Thanks! Applied to the 0.11 version with a few changes.

Modify Ticket

Change Properties
Set your email in Preferences
Action
as closed The owner will remain Alec Thomas.
The resolution will be deleted. Next status will be 'reopened'.

Add Comment

E-mail address and name can be saved in the Preferences.

Attachments ↑ Description ↑
 
Note: See TracTickets for help on using tickets.