Modify

Opened 6 years ago

Closed 6 years ago

#8005 closed defect (fixed)

[patch] get_htdocs_dirs() method should return a unique prefix

Reported by: Jun Omae Owned by: Steffen Hoffmann
Priority: low Component: DataSaverPlugin
Severity: normal Keywords: i18n
Cc: Trac Release: 0.12

Description

DataSaverModule.get_htdocs_dirs returns 'htdocs' as prefix. The 'htdocs' is a very common word.

I think that DataSaverPlugin should use datasaver. datasaver-prefix.diff

Attachments (1)

datasaver-prefix.diff (1.0 KB) - added by Jun Omae 6 years ago.

Download all attachments as: .zip

Change History (3)

Changed 6 years ago by Jun Omae

Attachment: datasaver-prefix.diff added

comment:1 in reply to:  description Changed 6 years ago by Steffen Hoffmann

Keywords: i18n added
Status: newassigned
Summary: DataSaverModule.get_htdocs_dirs should return a unique prefix[patch] get_htdocs_dirs() method should return a unique prefix

Replying to jun66j5:

![...] I think that DataSaverPlugin should use datasaver. datasaver-prefix.diff

I think this too, as this is a universal rule, not only for DataSaverPlugin.

Thanks for catching this as is was certainly done by me by mistake. Must have been to busy looking for the special JS i18n implementation details for this plugin, so overlooked this.

No harm done by now, but if more plugins would resort to the unintended «htdocs» namespace, this could cause nasty effects. I'll fix it right away, before someone else copies this for his/her own plugin.

comment:2 Changed 6 years ago by Steffen Hoffmann

Resolution: fixed
Status: assignedclosed

(In [9406]) DataSaverPlugin: Correct indesired i18n namespace, closes #8005.

Thanks to Jun Omae for finding this and suggesting the solution right away.

Modify Ticket

Change Properties
Set your email in Preferences
Action
as closed The owner will remain Steffen Hoffmann.
The resolution will be deleted. Next status will be 'reopened'.

Add Comment


E-mail address and name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.