Modify

Opened 7 years ago

Closed 7 years ago

Last modified 7 years ago

#8061 closed defect (fixed)

[Patch] A input element has no child nodes

Reported by: Jun Omae Owned by: Steffen Hoffmann
Priority: normal Component: AccountManagerPlugin
Severity: normal Keywords: malformed HTML
Cc: Trac Release: 0.12

Description

A input element has no child nodes, However input element has elements and text nodes in admin_accountsconfig.html and admin_accountsnotification.html. Thenn, admin panel responds malformed html.

Please apply input-no-child-nodes.diff to fix the issue.

Attachments (1)

input-no-child-nodes.diff (3.9 KB) - added by Jun Omae 7 years ago.

Download all attachments as: .zip

Change History (3)

Changed 7 years ago by Jun Omae

Attachment: input-no-child-nodes.diff added

comment:1 Changed 7 years ago by Steffen Hoffmann

Resolution: fixed
Status: newclosed

(In [9434]) AccountManagerPlugin: Move child nodes from input element to get valid HTML, closes #8061.

This causes minor changes to i18n, as one msgid is split into two. A new message catalog has been extracted and corresponding msgtxt's of existing translations have been fixed accordingly. Pending fix for one German translation is merged as well. Thanks to Jun Omae for reporting the issue and suggesting template changes.

comment:2 Changed 7 years ago by Steffen Hoffmann

Keywords: malformed HTML added

Jun, nothing stops you from finishing your translation now, as your report indicates, that you're most probably working on Japanese translations for AccountManagerPlugin.

I thank you very much for your code review, as you already did with other plugins before. Your continuous effort is most appreciated. Only I can't give you multiple kudos at Ohloh. ;-)

Modify Ticket

Change Properties
Set your email in Preferences
Action
as closed The owner will remain Steffen Hoffmann.
The resolution will be deleted. Next status will be 'reopened'.

Add Comment


E-mail address and name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.