Modify

Opened 7 years ago

Closed 7 years ago

#8257 closed enhancement (fixed)

Display PasswordStore Option Docs on Configuration Page

Reported by: David A. Riggs Owned by: Steffen Hoffmann
Priority: normal Component: AccountManagerPlugin
Severity: normal Keywords: display configuration doc-string
Cc: Trac Release: 0.12

Description

The AccountManager "Configuration" page (template 'admin_accountsconfig.html') renders a form for editing the options of enabled PasswordStore implementations. This page does not currently render the docstrings for Options.

I have attached an initial patch (a whopping two lines) which renders the docstrings on this form.

Attachments (2)

accountmanager_doc_patch_r9560.diff (1002 bytes) - added by David A. Riggs 7 years ago.
Patch to r9560 which renders PasswordStore docstrings on the Configuration form
accountmanager_doc_patch_screenshot.png (141.8 KB) - added by David A. Riggs 7 years ago.
Screenshot showing docstrings rendered on Configuration form

Download all attachments as: .zip

Change History (4)

Changed 7 years ago by David A. Riggs

Patch to r9560 which renders PasswordStore docstrings on the Configuration form

Changed 7 years ago by David A. Riggs

Screenshot showing docstrings rendered on Configuration form

comment:1 Changed 7 years ago by Steffen Hoffmann

Keywords: display configuration doc-string added
Status: newassigned

Nice, I've just tested your modification. Looks really useful, and strings display done with CSS style selected by Trac's special class="help" integrates seamlessly with current page style.

I'll add i18n support and push it out afterwards. Thank you very much for your valuable contribution.

comment:2 Changed 7 years ago by Steffen Hoffmann

Resolution: fixed
Status: assignedclosed

(In [9587]) AccountManagerPlugin: Add option doc-strings to configuration admin page, closes #8257.

I've extended the changes suggested by David A. Riggs with i18n markup and will require future doc-strings to be translatable before adding them to the AcctMgr source. There's no sane way to force the same on IPasswordStore's provided as external plugin, but I'm asking very kindly to follow that policy.

Modify Ticket

Change Properties
Set your email in Preferences
Action
as closed The owner will remain Steffen Hoffmann.
The resolution will be deleted.

Add Comment


E-mail address and name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.