parentheses in milestone name confuse plugin macros, they show empty content then

[falkb]

Give a milestone this name:

S2-DX2 - N3 (test)

Then

[[BurndownChart(milestone=S2-DX2 - N3 (test), startdate=2010-06-11)]]

[[WorkloadChart(milestone=S2-DX2 - N3 (test))]]

remain empty, and

[[HoursRemaining(milestone=S2-DX2 - N3 (test))]]

displays just 0 although I have some tickets for that milestone with remaining hours set.

If I do not use parentheses in the milestone name, everything works well. Spaces in the name are not a problem.

(seen with Bitnami Trac 0.12.1, Native on Windows), EstimationTools-0.4.5-py2.5.egg

[Adrian Fritz]

Reproduced. Trac 0.12 on Linux. Tested also with only ( or ).

[anonymous]

Test details - Error messages

MIlestone	Contains	WorkloadChart	BurndownChart	HoursRemaining
"2011-05 (test)"	both ( & )	blank	blank	0
"(2011-05 test"	leading (	blank	blank	0
"2011-05 (test"	intermediate (	blank	blank	0
"2011-05 test)"	trailing )	blank	blank	0

Looks like the issue is in _calculate_timetable (@ ​http://trac-hacks.org/browser/estimationtoolsplugin/trunk/estimationtools/burndownchart.py?rev=10082#L144)

[Adrian Fritz]

sorry, forgot to login

Just a note for my-self: @​http://trac-hacks.org/browser/estimationtoolsplugin/trunk/estimationtools/burndownchart.py?rev=10082#L13:

• from: 'bgcolor': 'ffffff00', 'wecolor':'ccccccaa', 'colorexpected': 'ffddaa', 'weekends':'true', 'gridlines' : '0'}
• to: 'bgcolor': 'ffffff', 'wecolor':'cccccc', 'colorexpected': 'ffddaa', 'weekends':'true', 'gridlines' : '0'}

[falkb]

Replying to anonymous:

Looks like the issue is in _calculate_timetable (@ ​http://trac-hacks.org/browser/estimationtoolsplugin/trunk/estimationtools/burndownchart.py?rev=10082#L144)

Maybe ​http://trac-hacks.org/browser/estimationtoolsplugin/trunk/estimationtools/utils.py#L131 must simply consider "(" and ")" as well. At least it's called by _calculate_timetable

[osimons]

Unquote parenthesis in query.

[osimons]

Replying to falkb:

Maybe estimationtoolsplugin/trunk/estimationtools/utils.py#L131​ must simply consider "(" and ")" as well. At least it's called by _calculate_timetable

That looks to be the correct solution, but please test attachment:t8299-query_paranthesis-r10557.diff​

[anonymous]

Replying to osimons:

That looks to be the correct solution, but please test attachment:t8299-query_paranthesis-r10557.diff​

Patch works well! Fixed. Thanks very much. :-)

[osimons]

(In [10617]) EstimationToolsPlugin: Milestone names with '(' or ')' in them display no data. Need to unquote parenthesis for query arguments. Closes #8299.