Modify

Opened 6 years ago

Closed 6 years ago

#8471 closed defect (worksforme)

Attaching to blog does not work in 0.12

Reported by: ak@… Owned by: Odd Simon Simonsen
Priority: normal Component: FullBlogPlugin
Severity: normal Keywords:
Cc: Trac Release: 0.12

Description

Attaching of files did not work after upgrading from 0.11 to 0.12. Fixed by changing the attach include in fullblog_view.html to what is now used in Trac 0.12 template pages...

Attachments (1)

FullBlogAttachFix.patch (778 bytes) - added by anonymous 6 years ago.

Download all attachments as: .zip

Change History (4)

Changed 6 years ago by anonymous

Attachment: FullBlogAttachFix.patch added

comment:1 Changed 6 years ago by Odd Simon Simonsen

Sorry, but I'm not able to replicate this. It works fine for me running latest 0.12.2 without patch. I have no problems using any attachment feature in blog.

I know that we've changed in Trac from a single macros.html file to putting each macro in its own file for include instead. However, for 0.12 there should be no breaking changes as the old macros file includes the attachment snippets for backwards-compat.

The plugin supports both 0.11 and 0.12, and I don't want to branch the plugin code unless I really have to. Anyway, without being able to replicate the reported issue that is unlikely for now at least ;-) Do you perhaps use some custom theme, site.html, custom templates or somehow use other layout code? Anything that may interfere?

comment:2 Changed 6 years ago by ak@…

No prob... I'm using quite a lot of plugins so no idea which one might cause it. Theme is the Gamedev one, no site.html ... I'll try to disable everything I can, re-run the test and see if I can still reproduce it. Feel free to close this ticket, I'll re-open it if and when I can reproduce it with a clean setup and after making sure the trac build I've used isn't causing it.

comment:3 Changed 6 years ago by Odd Simon Simonsen

Resolution: worksforme
Status: newclosed

Quite sure this works, and no further feedback to suggest otherwise. Closing.

Modify Ticket

Change Properties
Set your email in Preferences
Action
as closed The owner will remain Odd Simon Simonsen.
The resolution will be deleted.

Add Comment


E-mail address and name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.