#8513 closed defect (invalid)
Error in patch?
Reported by: | Andy Baker | Owned by: | CM Lubinski |
---|---|---|---|
Priority: | normal | Component: | MultiSelectCustomFieldsPatch |
Severity: | normal | Keywords: | |
Cc: | Trac Release: | 0.12 |
Description
In query.py shouldn't the change be
+ modes['multi'] = [ + {'name': _("contains"), 'value': "~"}, + {'name': _("does not contain"), 'value': "!~"},
and not
+ modes['multi'] = [ + {'name': _("contains"), 'value': "|"}, + {'name': _("does not contain"), 'value': "!"},
Attachments (0)
Change History (4)
comment:1 Changed 14 years ago by
comment:2 Changed 13 years ago by
Resolution: | → invalid |
---|---|
Status: | new → closed |
I don't believe this addition is correct. Using a pipe indicates a different mode. Using a tilde would cause the '%' + value + '%' search to be used. Multiselect values should always end in a |, hence '%' + value + '|%' should be the search.
comment:3 Changed 13 years ago by
Seems like this is a different request, but the same confusion found in #9731. Did you convert a normal select into a multi-select? If so, you'd need to append a pipe to all existing values. I'll add instructions on how to do this in the wiki.
comment:4 Changed 13 years ago by
It was for an old client and I no longer have the full code. It's unlikely that the patch failed to get through test with the client, but then that could be just luck (as in the config was established with a trailing pipe).
Replying to bungybun@gmail.com:
Have you gotten to test this out with the corrections? Also, how do you install this patch?