Modify

Opened 6 years ago

Closed 5 years ago

Last modified 5 years ago

#8513 closed defect (invalid)

Error in patch?

Reported by: Andy Baker Owned by: CM Lubinski
Priority: normal Component: MultiSelectCustomFieldsPatch
Severity: normal Keywords:
Cc: Trac Release: 0.12

Description

In query.py shouldn't the change be

+        modes['multi'] = [
+            {'name': _("contains"), 'value': "~"},
+            {'name': _("does not contain"), 'value': "!~"},

and not

+        modes['multi'] = [
+            {'name': _("contains"), 'value': "|"},
+            {'name': _("does not contain"), 'value': "!"},

Attachments (0)

Change History (4)

comment:1 in reply to:  description Changed 6 years ago by Josh

Replying to bungybun@gmail.com:

In query.py shouldn't the change be

+        modes['multi'] = [
+            {'name': _("contains"), 'value': "~"},
+            {'name': _("does not contain"), 'value': "!~"},

and not

+        modes['multi'] = [
+            {'name': _("contains"), 'value': "|"},
+            {'name': _("does not contain"), 'value': "!"},

Have you gotten to test this out with the corrections? Also, how do you install this patch?

comment:2 Changed 5 years ago by CM Lubinski

Resolution: invalid
Status: newclosed

I don't believe this addition is correct. Using a pipe indicates a different mode. Using a tilde would cause the '%' + value + '%' search to be used. Multiselect values should always end in a |, hence '%' + value + '|%' should be the search.

comment:3 Changed 5 years ago by CM Lubinski

Seems like this is a different request, but the same confusion found in #9731. Did you convert a normal select into a multi-select? If so, you'd need to append a pipe to all existing values. I'll add instructions on how to do this in the wiki.

comment:4 Changed 5 years ago by Andy Baker

It was for an old client and I no longer have the full code. It's unlikely that the patch failed to get through test with the client, but then that could be just luck (as in the config was established with a trailing pipe).

Modify Ticket

Change Properties
Set your email in Preferences
Action
as closed The owner will remain CM Lubinski.
The resolution will be deleted.

Add Comment


E-mail address and name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.