Modify

Opened 11 years ago

Closed 11 years ago

Last modified 8 years ago

#853 closed defect (fixed)

pdf conversion misses images if wiki not on standard port

Reported by: anonymous Owned by: Alec Thomas
Priority: normal Component: PageToPdfPlugin
Severity: normal Keywords:
Cc: Trac Release: 0.9

Description (last modified by Noah Kantrowitz)

PDF conversion was missing images because my web server running Trac is not on a standard port. When I changed the line that is supposed to correct the image links from:

 page = re.sub('<img src="(?!\w+://', '<img src="%s://%s' % (req.scheme, req.server_name), page)

to:

 page = re.sub('<img src="(?!\w+://', '<img src="%s://%s:%d' % (req.scheme, req.server_name, req.server_port), page)

Then it now works ok for me.

Thanks for a very useful plugin!

Attachments (0)

Change History (2)

comment:1 Changed 11 years ago by Noah Kantrowitz

Description: modified (diff)

Fixing formatting

comment:2 Changed 11 years ago by Noah Kantrowitz

Resolution: fixed
Status: newclosed

(In [1462]) Allow non-standard ports. Fixes #853.

Modify Ticket

Change Properties
Set your email in Preferences
Action
as closed The owner will remain Alec Thomas.
The resolution will be deleted.

Add Comment


E-mail address and name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.