Modify ↓
Opened 14 years ago
Closed 8 years ago
#8620 closed defect (wontfix)
[Patch] Small grammatical fix in the ticket_email_mimic.html email
Reported by: | Jae Chang | Owned by: | |
---|---|---|---|
Priority: | normal | Component: | AnnouncerPlugin |
Severity: | normal | Keywords: | |
Cc: | Ryan J Ollos, Robert Corsaro | Trac Release: | 0.12 |
Description (last modified by )
I have a picky user that complained about this line in the html email:
- Resolution changed from [shouldn't something be here?] to Fixed.
The old resolution was simply a <blank> value. Thus the patch simply checks for a value before printing the preceding "from".
Now, if the old resolution has no value, it becomes:
- Resolution changed to Fixed.
Attachments (1)
Change History (6)
Changed 14 years ago by
Attachment: | patch.diff added |
---|
comment:1 Changed 14 years ago by
Description: | modified (diff) |
---|---|
Summary: | Small grammatical fix in the ticket_email_mimic.html email → [Patch] Small grammatical fix in the ticket_email_mimic.html email |
comment:2 Changed 12 years ago by
comment:3 Changed 12 years ago by
Cc: | Ryan J Ollos Robert Corsaro added; anonymous removed |
---|---|
Owner: | changed from Robert Corsaro to Steffen Hoffmann |
Couldn't resist to do that change, especially for such a remarkable change number.
comment:4 Changed 8 years ago by
Owner: | Steffen Hoffmann deleted |
---|
comment:5 Changed 8 years ago by
Resolution: | → wontfix |
---|---|
Status: | new → closed |
Please upgrade to Trac 1.2, which has integrated the core of AnnouncerPlugin. Please raise the issue on the trac:MailingList if you encounter the issue with Trac 1.2.
Note: See
TracTickets for help on using
tickets.
(In [12345]) TracAnnouncer: Improve ticket change notification template, refs #8620.
Feels like there must be more corner-cases, that are not handled optimal now, but this is an easy win, so won't miss it for older announcer versions as well.
Thanks to jc2trachacks for taking care to report as well as for providing a good starting point towards the actual fix (omit the empty old value too).