Modify

Opened 6 years ago

Last modified 3 months ago

#8620 new defect

[Patch] Small grammatical fix in the ticket_email_mimic.html email

Reported by: Jae Chang Owned by:
Priority: normal Component: AnnouncerPlugin
Severity: normal Keywords:
Cc: Ryan J Ollos, Robert Corsaro Trac Release: 0.12

Description (last modified by Ryan J Ollos)

I have a picky user that complained about this line in the html email:

  • Resolution changed from [shouldn't something be here?] to Fixed.

The old resolution was simply a <blank> value. Thus the patch simply checks for a value before printing the preceding "from".

Now, if the old resolution has no value, it becomes:

  • Resolution changed to Fixed.

Attachments (1)

patch.diff (943 bytes) - added by Jae Chang 6 years ago.

Download all attachments as: .zip

Change History (5)

Changed 6 years ago by Jae Chang

Attachment: patch.diff added

comment:1 Changed 6 years ago by Ryan J Ollos

Description: modified (diff)
Summary: Small grammatical fix in the ticket_email_mimic.html email[Patch] Small grammatical fix in the ticket_email_mimic.html email

comment:2 Changed 4 years ago by Steffen Hoffmann

(In [12345]) TracAnnouncer: Improve ticket change notification template, refs #8620.

Feels like there must be more corner-cases, that are not handled optimal now, but this is an easy win, so won't miss it for older announcer versions as well.

Thanks to jc2trachacks for taking care to report as well as for providing a good starting point towards the actual fix (omit the empty old value too).

comment:3 Changed 4 years ago by Steffen Hoffmann

Cc: Ryan J Ollos Robert Corsaro added; anonymous removed
Owner: changed from Robert Corsaro to Steffen Hoffmann

Couldn't resist to do that change, especially for such a remarkable change number.

comment:4 Changed 3 months ago by Ryan J Ollos

Owner: Steffen Hoffmann deleted

Modify Ticket

Action
as new The ticket will remain with no owner.

Add Comment


E-mail address and name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.