burndown graph should not finish with milestone's 'due' date but with 'completed' date

[falkb]

I have a burndown graph

 [[BurndownChart(milestone=Foo, startdate=2011-03-10)]]

in a milestone that was not finished until the 'due' date of the milestone. Unfortunately, I cannot see the development of the remaining hours from that 'due' date until today, because the Burndown graph does end with the 'due' date.

That is why the burndown graph should display the range until the 'completed' date of the milestone, maybe in a red colour between 'due' and 'completed' date to mark it as overdue.

[osimons]

Oh, I see - it will only display the time between 'due' and 'completed' AFTER the milestone is actually completed. So when checking 'due' we should not actually use it unless it is a timestamp in the future. If 'due' is in the past, we just use the current 'now' as enddate.

Makes sense. Should be a simple patch. I'll look into it.

[osimons]

Patch to not use milestone 'due' if it is in the past.

[anonymous]

Patch works! Thanks.

P.S.:
Replying to falkb:

... the burndown graph should display ... in a red colour between 'due' and 'completed' date to mark it as overdue.

Or maybe a vertical red line at 'due' date to show we've exceeded the limit

[osimons]

Replying to anonymous:

Or maybe a vertical red line at 'due' date to show we've exceeded the limit

This is really a separate request, as the plugin does not yet have any means of tagging custom events or otherwise drawing anything other than the line. #4131 and #4217 also requests some variation markings, so please transfer your ideas to one of those tickets or create a new ticket for it. This particular 'due' vs 'completed' vs 'today' as value for enddate is just one possible use for such a general marking-feature.

I'll get the patch for enddate calculation committed, though.

[osimons]

(In [10082]) EstimationToolsPlugin: Don't use milestone 'due' date if it falls in the past, as data between 'due' and 'today' wont then be charted.

Fixes #8695. Thanks to falkb for report.

[falkb]

Replying to osimons:

Replying to anonymous:

Or maybe a vertical red line at 'due' date to show we've exceeded the limit

#4131 and #4217 also requests some variation markings

#4131 would be a good solution for showing the overdue 'due' date also. So I wont create a new ticket.