Modify ↓
Opened 13 years ago
Closed 13 years ago
#8814 closed defect (fixed)
Generic word `for` is extracted, the term is difficult to translate in Japanese
Reported by: | Jun Omae | Owned by: | Steffen Hoffmann |
---|---|---|---|
Priority: | normal | Component: | AccountManagerPlugin |
Severity: | normal | Keywords: | i18n |
Cc: | Trac Release: | 0.11 |
Description
Please apply the following patch that don't separate messages, if you can.
-
acct_mgr/templates/account_details.html
16 16 <div id="header"> 17 17 <h2>Review User Account Details</h2> 18 18 <py:choose> 19 <p py:when="name" >for <b>${name}</b> (<em>${user}</em>)</p>20 <p py:otherwise="" >for <b>${user}</b></p>19 <p py:when="name" i18n:msg="name,user">for <b>${name}</b> (<em>${user}</em>)</p> 20 <p py:otherwise="" i18n:msg="user">for <b>${user}</b></p> 21 21 </py:choose> 22 22 </div> 23 23
Attachments (0)
Change History (2)
comment:1 Changed 13 years ago by
Keywords: | i18n added |
---|---|
Status: | new → assigned |
comment:2 Changed 13 years ago by
Resolution: | → fixed |
---|---|
Status: | assigned → closed |
(In [10242]) AccountManagerPlugin: (i18n) Patch account_details.html
template, closes #8814.
Improved markup has been done similar to recommendation by Jun Omae, thanks! Adds 1 msgid on catalog update. Hopefully I made the template more readable too by shortening lines below the 80 chars limit.
Note: See
TracTickets for help on using
tickets.
Sure, I can and I certainly care for this type of issues, as I'm pushing i18n as well. Thanks for pointing this out.
Sometimes it's hard to spot such rough edges when I do a lot of coding without re-reading later. Your code review and testing is highly appreciated, as always.