Absolute href are broken if trac is installed in root path

[anonymous]

Hi,

If an absolute href is broken trac is installed at root of the domain.

For exemple, if you install your trac at http://trac.myproject.org/ and configure

[mainnav]
wiki.href = /wiki/Home

then TracMenus generates href 'wiki/Home'. This broke the link. (wiki is a netloc).

The offending code is : ​http://trac-hacks.org/browser/menusplugin/0.11/tracmenus/web_ui.py#L139

menu[name]['label']=menu[name].setdefault('label', html.a())(href=value.startswith('/') and req.href()+value or value)

reg.href() returns '/'. You should trim beginning '' in the resulting href.

Regards, Étienne

[Ryan J Ollos]

Duplicate of #8877, but thanks for the hint at a solution.

[Ryan J Ollos]

(In [11038]) Fixes #7399, Refs #7680, #8877, #8953: (0.1.1) Links were invalid when Trac was accessed from the top-most path.

[Ryan J Ollos]

(In [11039]) Fixes #7399, Refs #7680, #8877, #8953: (0.1.1) [11038] was the wrong solution. This fix should work better.

[Ryan J Ollos]

(In [11154]) Fixes #7399, Refs #7680, #8877, #8953: Allow Href to take care of path joining. Tested in 0.11 and 0.13dev-r10909.

[Ryan J Ollos]

(In [11155]) Fixes #7399, Refs #7680, #8877, #8953: Removed egg and pydev files accidentally committed in [11154].

[Ryan J Ollos]

(In [11156]) Fixes #7399, Refs #7680, #8877, #8953: Removed egg and pydev files accidentally committed in [11154].

[Ryan J Ollos]

(In [11166]) Fixes #7399, Refs #7680, #8877, #8953: Yet another attempt to fix invalid links when req.href = '/'. If the href for a menu item specifies a relative path, the trailing forward slashes are stripped from req.href() so that the two cases are handled: 1) req.href() is '/' and 2) req.href() is '/somepath'.