fail on fresh install CentoOS 5.6

[anonymous]

Most recent call last:

Traceback (most recent call last):

File "build/bdist.linux-i686/egg/trac/web/main.py", line 511, in _dispatch_request File "build/bdist.linux-i686/egg/trac/web/main.py", line 192, in dispatch File "build/bdist.linux-i686/egg/trac/core.py", line 78, in extensions File "build/bdist.linux-i686/egg/trac/core.py", line 213, in getitem File "build/bdist.linux-i686/egg/trac/core.py", line 119, in maybe_init File "build/bdist.linux-i686/egg/testmanager/api.py", line 88, in init

AttributeError: 'unicode' object has no attribute 'partition'

[anonymous]

api.py

@@ -85 +85 @@
                 if row[0] == 'default':
                     self.default_outcome = row[1].lower()
                 else:
-                    color = row[0].partition('.')[0]
-                    outcome = row[0].partition('.')[2].lower()
+                    color = row[0].split('.',1)[0]
+                    outcome = row[0].split('.',1)[-1].lower()
                     caption = row[1]
 
                     if color not in self.outcomes_by_color:
@@ -311 +311 @@
             elif type == 'testplan':
                 req.perm.require('TEST_PLAN_ADMIN')
                 
-                catid = path.rpartition('_TT')[2]
+                catid = path.split('_TT')[-1]
 
                 try:
                     # Add the new test plan in the database
@@ -345 +345 @@
                         tcIdsList = [tcId]
                     
                     try:
-                        catid = path.rpartition('_TT')[2]
+                        #catid = path.rpartition('_TT')[2]
+                       catid = path.split('_TT')[-1]
                         tcat = TestCatalog(self.env, catid)
                         
                         for tcId in tcIdsList:
                             if tcId is not None and tcId != '':
                                 old_pagename = tcId
-                                tc_id = tcId.rpartition('_TC')[2]
+                                #tc_id = tcId.rpartition('_TC')[2]
+                                tc_id = tcId.split('_TC')[-1]
 
                                 tc = TestCase(self.env, tc_id, tcId)
                                 tc.author = author
@@ -375 +377 @@
                         req.redirect(req.href.wiki(pagename))
                 
                     # Redirect to test catalog, forcing a page refresh by means of a random request parameter
-                    req.redirect(req.href.wiki(pagename.rpartition('_TC')[0], random=str(datetime.now(utc).microsecond)))
+                    #req.redirect(req.href.wiki(pagename.rpartition('_TC')[0], random=str(datetime.now(utc).microsecond)))
+                    req.redirect(req.href.wiki('_TC'.join(pagename.split('_TC')[:-1]), random=str(datetime.now(utc).microsecond)))
                     
                 elif duplicate and duplicate != '':
                     # Duplicate test case
-                    old_id = tcId.rpartition('_TC')[2]
+                    #old_id = tcId.rpartition('_TC')[2]
+                    old_id = tcId.split('_TC')[-1]
                     old_pagename = tcId
                     try:
                         old_tc = TestCase(self.env, old_id, old_pagename)
@@ -430 +434 @@
                 req.perm.require('TEST_PLAN_ADMIN')
                 
                 planid = req.args.get('planid')
-                catid = path.rpartition('_TT')[2]
+                #catid = path.rpartition('_TT')[2]
+                catid = path.split('_TT')[-1]
 
                 self.env.log.debug("About to delete test plan %s on catalog %s" % (planid, catid))

[anonymous]

I hacked up the partition/rpartition stuff with split and rsplit. I doing so there are too many places where the path is being analyzed and where the same bits of code exist over and over. These path functions SHOULD be refactored into the util.py module to reduce chance for bugs like the one in get_enclosing_catalog in model.py

else:
            #cat_id = page_name.rpartition('TT')[0].page_name.rpartition('TT')[2].rpartition('_')[0]
            # XXX THIS LOOKS LIKE A BUG. STRING FROM FIRST rpartition WILL NOT HAVE ATTRIBUTE page_name
            cat_id = page_name.rsplit('TT',1)[0].rsplit('TT',1)[-1].rsplit('_',1)[0]

[Roberto Longobardi]

Hi, I guess the problem is your Python version.

Only versions 2.5+ are supported. See also #4846.

Consider that Python 2.4 is not supported by Trac either.

I'll think about using split instead of partition. In the meantime, you can add the following functions to "utils.py":

def partition(str, ch):

        idx = str.find(ch)

        if idx >= 0:
                return (str[0:idx], ch, str[idx+1:])
        else:
                return (str,'','')

def rpartition(str, ch):

        idx = str.rfind(ch)

        if idx >= 0:
                return (str[0:idx], ch, str[idx+1:])
        else:
                return ('','',str)

And replace every occurrence of their use as follows:

somestring.partition('A') ====> partition(somestring, 'A')
somestring.rpartition('A') ====> rpartition(somestring, 'A')

Ciao, Roberto