Using root= for a ticket in the middle of a hierarchy breaks rollup

[Chris Nelson]

If you have a hierarchy like

A
 B
  C
  D
 E
  F
  G

and display a Gantt with root=B, C and D are not indented and B does not show the cumulative time for them.

[Chris Nelson]

(In [10475]) Changes root ticket's parents to 0 for easier processing. Refs #8993

[Ryan J Ollos]

Following this change, with a macro call [[TracJSGanttChart(milestone=M1 - I9,lwidth=800,colorBy=owner)]], the parent tickets no longer span the child ticket's start and end dates:

At r10474:

[Chris Nelson]

Replying to rjollos:

Following this change, with a macro call [[TracJSGanttChart(milestone=M1 - I9,lwidth=800,colorBy=owner)]], the parent tickets no longer span the child ticket's start and end dates: ...

So this change causes the problem for you that it fixes for me? :-(

Try this (untested):

tracjsgantt/tracjsgantt.py

@@ -701 +701 @@
             task += '%s,' % 0
         
         # pParent (parent task ID) 
-        if options['root'] and str(ticket['id']) not in options['root'].split('
+        if self.fields['parent'] \
+                and (not options['root'] 
+                     or str(ticket['id']) not in options['root'].split('|')):
             task += '%s,' % ticket[self.fields['parent']]
         else:
             task += '%s,' % 0

[Ryan J Ollos]

I will be testing and getting back to you shortly. Thanks!

[Chris Nelson]

(In [10479]) Fixed bug when root was not specified. Refs #8993.

[Ryan J Ollos]

I updated to r10479 and it's working well. Thanks!

[Chris Nelson]

(In [10529]) Fixed bug when root==self, and root had parents. Refs #8993.

When root==self, the current ticket's id couldn't appear in root because root equaled 'self' rather then the id it represents. This fix checks the current ticket's id when root==self.