Modify

Opened 6 years ago

Closed 6 years ago

Last modified 6 years ago

#8995 closed defect (fixed)

Some missing HTML on wiki edit page

Reported by: Ryan J Ollos Owned by: Steffen Hoffmann
Priority: normal Component: TagsPlugin
Severity: normal Keywords: i18n Genshi markup
Cc: cpatzer Trac Release: 0.11

Description

With r10448 of the trunk, on the Wiki edit page:

Attachments (1)

TagUnderBadHtml.png (30.3 KB) - added by Ryan J Ollos 6 years ago.

Download all attachments as: .zip

Change History (10)

Changed 6 years ago by Ryan J Ollos

Attachment: TagUnderBadHtml.png added

comment:1 Changed 6 years ago by Ryan J Ollos

Cc: anonymous added; Steffen Hoffmann removed
Owner: changed from Michael Renzmann to Steffen Hoffmann

I'm guessing this is related to [9316].

comment:2 Changed 6 years ago by Ryan J Ollos

I'm not certain that this is the best fix, but it does the job,

  • trunk/tractags/wiki.py

     
    136136        # TRANSLATOR: Label text for link to '/tags'.
    137137        link = tag.a(_("view all tags"), href=req.href.tags())
    138138        # TRANSLATOR: ... (view all tags)
    139         insert = tag(_("Tag under: (%(tags_link)s)", tags_link=link))
     139        insert = tag(_("Tag under: ("), link, ")")
    140140        insert(
    141141            tag.br(),
    142142            tag.input(id='tags', type='text', name='tags', size='50',

comment:3 Changed 6 years ago by Ryan J Ollos

Summary: Some bad HTML on wiki edit pageSome missing HTML on wiki edit page

comment:4 Changed 6 years ago by Ryan J Ollos

This patch might be cleaner. I haven't worked with Genshi much, so I can't say for sure.

  • trunk/tractags/wiki.py

     
    136136        # TRANSLATOR: Label text for link to '/tags'.
    137137        link = tag.a(_("view all tags"), href=req.href.tags())
    138138        # TRANSLATOR: ... (view all tags)
    139         insert = tag(_("Tag under: (%(tags_link)s)", tags_link=link))
     139        insert = tag(_("Tag under"), ": (", link, ")")
    140140        insert(
    141141            tag.br(),
    142142            tag.input(id='tags', type='text', name='tags', size='50',

comment:5 in reply to:  1 Changed 6 years ago by Steffen Hoffmann

Keywords: i18n Genshi markup added

Replying to rjollos:

I'm guessing this is related to [9316].

No, rather an aftermath of [10414], obviously the markup is not recognized but escaped.

Regarding the patches, both don't respect i18n: Control over sentence structure is a requirement, so we need the string expansion for flexible positioning of the link in relation to the text. In one country it reads "Blah fuss LINK", while in another "Blah LINK fuss", and... (well, you'll certainly get the picture)

comment:6 Changed 6 years ago by Steffen Hoffmann

(In [10481]) TagsPlugin: Fix wrong escape of HTML from Genshi markup, refs #8995.

The string substitution must be preserved for full i18n support.

comment:7 Changed 6 years ago by Ryan J Ollos

Resolution: fixed
Status: newclosed

Thanks for the fix! It is working well for me. I need to spend some time reading the Genshi docs ...

comment:8 Changed 6 years ago by Ryan J Ollos

Cc: cpatzer added; anonymous removed

comment:9 Changed 6 years ago by Ryan J Ollos

#10032 closed as a duplicate.

Modify Ticket

Change Properties
Set your email in Preferences
Action
as closed The owner will remain Steffen Hoffmann.
The resolution will be deleted.

Add Comment


E-mail address and name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.