Modify

Opened 13 years ago

Closed 8 years ago

#9106 closed enhancement (wontfix)

Python 2.4 Compatibility

Reported by: Guido U. Draheim Owned by:
Priority: normal Component: AnnouncerPlugin
Severity: normal Keywords: compatibility
Cc: Ryan J Ollos, Robert Corsaro Trac Release: 0.11

Description

Trac 0.12 does still officially support Python 2.4 - here are a couple of patches to allow the plugin to compile with it.

  • trac-announcer-plugin-unstable/trac-announcer-plugin.no-empty-yield-acct_mgr-announce-01.patch
  • trac-announcer-plugin-unstable/trac-announcer-plugin.no-empty-yield-bitten-announce-01.patch

Prebuilt packages for CentOs-5 / RHEL5 may be downloaded from the Open Build System at https://build.opensuse.org/package/show?package=trac-announcer-plugin-unstable&project=home%3Aguidod%3Atrac12

Attachments (3)

trac-announcer-plugin.no-empty-yield-acct_mgr-announce-01.patch (214 bytes) - added by Guido U. Draheim 13 years ago.
trac-announcer-plugin.no-empty-yield-bitten-announce-01.patch (210 bytes) - added by Guido U. Draheim 13 years ago.
20110105-06_anonymous_python2.4-fixes.patch (1.9 KB) - added by Steffen Hoffmann 12 years ago.
moving anonymous patch data from wiki:AnnouncerPlugin in here

Download all attachments as: .zip

Change History (13)

comment:1 Changed 12 years ago by Steffen Hoffmann

Cc: Ryan J Ollos Robert Corsaro added; anonymous removed
Keywords: compatibility added
Owner: changed from Robert Corsaro to Steffen Hoffmann
Priority: lownormal
Trac Release: 0.120.11

Seemingly more complete patches have been added as anonymous contribution to the main wiki page for this plugin between 05-Jan-2011 and 06-Jan-2011 with reference to Python2.4 on Centos 5.4.

IMHO the overlap provides confirmation for aforementioned changes, but some new code to verify is introduced as well. Moving it in here now from the wiki page according to our preferred style for contributions and issue tracking.

Changed 12 years ago by Steffen Hoffmann

moving anonymous patch data from wiki:AnnouncerPlugin in here

comment:2 Changed 11 years ago by Ryan J Ollos

#11428 and #11432 closed as duplicates.

comment:3 Changed 11 years ago by Ryan J Ollos

I pushed a small change in [13963] to try and address SO:24117488. We should just apply attachment:20110105-06_anonymous_python2.4-fixes.patch though. Any objections to applying the patch?

comment:4 in reply to:  3 Changed 11 years ago by Steffen Hoffmann

Replying to rjollos:

I pushed a small change in [13963]

I see. Even better to have the reference at least from here.

Any objections to applying the patch?

None. Meanwhile I've encountered the issue with itemgetter not being part of Python2.4, so it looks like the right thing to do.

comment:5 Changed 11 years ago by Ryan J Ollos

Thanks for the feedback. I'll try to apply the patch in the next day or so.

comment:6 Changed 11 years ago by Ryan J Ollos

In 13968:

1.0dev: Python 2.4 compatibility patch. Refs #9106.

Patch by hasienda.

comment:7 Changed 11 years ago by Ryan J Ollos

I'll update the changelog message for [13963] so that it references this ticket.

comment:8 Changed 11 years ago by Ryan J Ollos

In 13963:

1.0dev: Python 2.4 compatibility. Refs #9106.

comment:9 Changed 8 years ago by Ryan J Ollos

Owner: Steffen Hoffmann deleted

comment:10 Changed 8 years ago by Ryan J Ollos

Resolution: wontfix
Status: newclosed

Modify Ticket

Change Properties
Set your email in Preferences
Action
as closed The ticket will remain with no owner.
The resolution will be deleted. Next status will be 'reopened'.

Add Comment


E-mail address and name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.