Too few colors, UTF8 issue

[anonymous]

Dear All i made a patch due to UTF8/ASCII issues (wip) and increased the number of usable colors.

The patch was from TicketCharts.py@8488.

[alexandre.cabrol@…]

Patch to increase number of colors, and manage string convertion (extra chars éè..., into ascii)

[Ivanelson Nunes]

-class TicketChart(WikiMacroBase):
+class TicketChartMacro(WikiMacroBase):

It seems that there is a difference in the name of the module!?

[Ryan J Ollos]

The class was recently renamed to conform to Trac conventions. You'll have to ignore that part of the patch.

[Ivanelson Nunes]

Replying to rjollos:

The class was recently renamed to conform to Trac conventions. You'll have to ignore that part of the patch.

Yes class! Sorry. I will delete these lines patch.

[Ryan J Ollos]

I'm not sure about the encoding that is done in the patch, and whether that is done correctly, but if the additional colors work well for you, I will go ahead and commit that portion of the patch.

[anonymous]

Replying to rjollos:

I'm not sure about the encoding that is done in the patch, and whether that is done correctly, but if the additional colors work well for you, I will go ahead and commit that portion of the patch.

If the number of colors is less than the number of keys will be exceptions such as:

list index out of range

If the patch fails or colors are not nice I go back to the original version.

[Ivanelson Nunes]

The patch failed!

ivan@dctvpsubu120012-bkp:/usr/local/lib/python2.7/dist-packages/TracTicketCharts-0.2dev-py2.7.egg/ticketcharts$ patch < TicketCharts.py.patch 
patching file TicketCharts.py
Hunk #1 FAILED at 90.
Hunk #2 succeeded at 223 (offset 23 lines).
Hunk #3 FAILED at 284.
Hunk #4 succeeded at 383 with fuzz 2 (offset 45 lines).
Hunk #5 FAILED at 374.
patch: **** malformed patch at line 77:

[Ryan J Ollos]

The codebase has changed significantly since the patch was created. I wouldn't worry about applying the patch anyway, and just directly add the additional colors to the source.

[Ryan J Ollos]

Replying to anonymous:

If the number of colors is less than the number of keys will be exceptions such as:

We should make sure to catch and handle that exception, or better yet, reuse the existing colors once they've all been exhausted. But more colors in the list can only help with this situation, right?

[Ivanelson Nunes]

Replying to rjollos:

The codebase has changed significantly since the patch was created. I wouldn't worry about applying the patch anyway, and just directly add the additional colors to the source.

I copied the patch only the list of colors and manually insert the original. see:

​https://dl.dropboxusercontent.com/u/35679162/Ticket_Status_by_Owner.PNG

I think it looks good.

[Ryan J Ollos]

Thanks for testing. I will apply the patch.

[Ryan J Ollos]

The patch for increasing the number of colors looks good. However, to handle unicode in the output, we should encode as UTF-8, not ascii. That will be handled in #6904.

[Ryan J Ollos]

(In [13246]) Fixes #9254: Increase number of colors from 6 to 119.