Modify

Opened 5 years ago

Closed 5 years ago

#9263 closed defect (fixed)

[Patch] After editing some ticket, empty string for float() error

Reported by: Ryan J Ollos Owned by: Chris Nelson
Priority: high Component: TracJsGanttPlugin
Severity: normal Keywords:
Cc: Trac Release: 0.11

Description

Further investigation in progress.

2011-10-13 13:03:07,047 Trac[formatter] ERROR: Macro TracJSGanttChart(milestone=M1 - I11, lwidth=600, colorBy=owner, expandClosedTickets=0, startDate=0, endDate=0, res=0) failed:
Traceback (most recent call last):
  File "/usr/lib/python2.6/site-packages/Trac-0.11.7-py2.6.egg/trac/wiki/formatter.py", line 484, in _macro_formatter
    return macro.process(args, in_paragraph=True)
  File "/usr/lib/python2.6/site-packages/Trac-0.11.7-py2.6.egg/trac/wiki/formatter.py", line 180, in process
    text = self.processor(text)
  File "/usr/lib/python2.6/site-packages/Trac-0.11.7-py2.6.egg/trac/wiki/formatter.py", line 167, in _macro_processor
    text)
  File "/usr/lib/python2.6/site-packages/Trac_jsGantt-0.9_r10732-py2.6.egg/tracjsgantt/tracjsgantt.py", line 1108, in expand_macro
    tasks = self._add_tasks(options)
  File "/usr/lib/python2.6/site-packages/Trac_jsGantt-0.9_r10732-py2.6.egg/tracjsgantt/tracjsgantt.py", line 1070, in _add_tasks
    self._schedule_tasks(options)
  File "/usr/lib/python2.6/site-packages/Trac_jsGantt-0.9_r10732-py2.6.egg/tracjsgantt/tracjsgantt.py", line 735, in _schedule_tasks
    _schedule_task_alap(t)
  File "/usr/lib/python2.6/site-packages/Trac_jsGantt-0.9_r10732-py2.6.egg/tracjsgantt/tracjsgantt.py", line 641, in _schedule_task_alap
    hours = self._workHours(t)
  File "/usr/lib/python2.6/site-packages/Trac_jsGantt-0.9_r10732-py2.6.egg/tracjsgantt/tracjsgantt.py", line 489, in _workHours
    est = float(ticket[self.fields['estimate']])
ValueError: empty string for float()

Attachments (1)

th9263-r10732-0-11-7.patch (529 bytes) - added by Ryan J Ollos 5 years ago.

Download all attachments as: .zip

Change History (11)

Changed 5 years ago by Ryan J Ollos

Attachment: th9263-r10732-0-11-7.patch added

comment:1 Changed 5 years ago by Ryan J Ollos

Here is a patch. The fix looks to be straightforward.

comment:2 Changed 5 years ago by Ryan J Ollos

Priority: normalhigh

comment:3 Changed 5 years ago by Ryan J Ollos

Summary: After editing some ticket, empty string for float() error[Patch] After editing some ticket, empty string for float() error

comment:4 Changed 5 years ago by Ryan J Ollos

comment:5 Changed 5 years ago by Ryan J Ollos

Sorry for the noise here, but f9bca5339fc4 contained a typo, so you'll also need 077175ace5a3.

https://bitbucket.org/rjollos/tracjsganttplugin/changeset/077175ace5a3

comment:6 in reply to:  4 ; Changed 5 years ago by Chris Nelson

Status: newassigned

Replying to rjollos:

I've pushed this change into my BitBucket fork (see also comment:3:ticket:9270).

https://bitbucket.org/rjollos/tracjsganttplugin/changeset/f9bca5339fc4

Is the patch here comprehensive or do I need to go to BitBucket?

comment:7 in reply to:  6 ; Changed 5 years ago by Ryan J Ollos

Replying to ChrisNelson:

Is the patch here comprehensive or do I need to go to BitBucket?

The patch in this ticket is comprehensive. I made an error when manually applying the patch to my BitBucket clone.

comment:8 in reply to:  7 Changed 5 years ago by Chris Nelson

Replying to rjollos:

Replying to ChrisNelson:

Is the patch here comprehensive or do I need to go to BitBucket?

The patch in this ticket is comprehensive. I made an error when manually applying the patch to my BitBucket clone.

OK.

I created a remote in my repo which points at your BitBucket. Cherry-picking from there should be both easier and more traceable than downloading patch files from TH.

I have some travel time coming up and plan to grab the patches onto my laptop and integrate them this week. Thanks.

comment:9 Changed 5 years ago by Chris Nelson

(In [10819]) Don't try to make a float from an empty strings. Refs #9263.

Thanks to rjollos for the patch.

comment:10 Changed 5 years ago by Ryan J Ollos

Resolution: fixed
Status: assignedclosed

Modify Ticket

Action
as closed The owner will remain Chris Nelson.
The resolution will be deleted. Next status will be 'reopened'.

Add Comment


E-mail address and name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.