Opened 6 years ago

Closed 6 years ago

[Patch] After editing some ticket, empty string for float() error

Reported by: Owned by: Ryan J Ollos Chris Nelson high TracJsGanttPlugin normal 0.11

Description

Further investigation in progress.

2011-10-13 13:03:07,047 Trac[formatter] ERROR: Macro TracJSGanttChart(milestone=M1 - I11, lwidth=600, colorBy=owner, expandClosedTickets=0, startDate=0, endDate=0, res=0) failed:
Traceback (most recent call last):
File "/usr/lib/python2.6/site-packages/Trac-0.11.7-py2.6.egg/trac/wiki/formatter.py", line 484, in _macro_formatter
return macro.process(args, in_paragraph=True)
File "/usr/lib/python2.6/site-packages/Trac-0.11.7-py2.6.egg/trac/wiki/formatter.py", line 180, in process
text = self.processor(text)
File "/usr/lib/python2.6/site-packages/Trac-0.11.7-py2.6.egg/trac/wiki/formatter.py", line 167, in _macro_processor
text)
File "/usr/lib/python2.6/site-packages/Trac_jsGantt-0.9_r10732-py2.6.egg/tracjsgantt/tracjsgantt.py", line 1108, in expand_macro
File "/usr/lib/python2.6/site-packages/Trac_jsGantt-0.9_r10732-py2.6.egg/tracjsgantt/tracjsgantt.py", line 735, in _schedule_tasks
File "/usr/lib/python2.6/site-packages/Trac_jsGantt-0.9_r10732-py2.6.egg/tracjsgantt/tracjsgantt.py", line 641, in _schedule_task_alap
hours = self._workHours(t)
File "/usr/lib/python2.6/site-packages/Trac_jsGantt-0.9_r10732-py2.6.egg/tracjsgantt/tracjsgantt.py", line 489, in _workHours
est = float(ticket[self.fields['estimate']])
ValueError: empty string for float()


comment:1 Changed 6 years ago by Ryan J Ollos

Here is a patch. The fix looks to be straightforward.

comment:2 Changed 6 years ago by Ryan J Ollos

Priority: normal → high

comment:3 Changed 6 years ago by Ryan J Ollos

Summary: After editing some ticket, empty string for float() error → [Patch] After editing some ticket, empty string for float() error

comment:5 Changed 6 years ago by Ryan J Ollos

Sorry for the noise here, but f9bca5339fc4 contained a typo, so you'll also need 077175ace5a3.

comment:6 in reply to:  4 ; follow-up:  7 Changed 6 years ago by Chris Nelson

Status: new → assigned

Is the patch here comprehensive or do I need to go to BitBucket?

comment:7 in reply to:  6 ; follow-up:  8 Changed 6 years ago by Ryan J Ollos

Is the patch here comprehensive or do I need to go to BitBucket?

The patch in this ticket is comprehensive. I made an error when manually applying the patch to my BitBucket clone.

comment:8 in reply to:  7 Changed 6 years ago by Chris Nelson

Is the patch here comprehensive or do I need to go to BitBucket?

The patch in this ticket is comprehensive. I made an error when manually applying the patch to my BitBucket clone.

OK.

I created a remote in my repo which points at your BitBucket. Cherry-picking from there should be both easier and more traceable than downloading patch files from TH.

I have some travel time coming up and plan to grab the patches onto my laptop and integrate them this week. Thanks.

comment:9 Changed 6 years ago by Chris Nelson

(In [10819]) Don't try to make a float from an empty strings. Refs #9263.

Thanks to rjollos for the patch.

comment:10 Changed 6 years ago by Ryan J Ollos

Resolution: → fixed assigned → closed

Modify Ticket

Change Properties