Modify

Opened 6 years ago

Closed 5 years ago

Last modified 5 years ago

#9272 closed enhancement (fixed)

commit request: pragma to be able to set dir, scale etc.

Reported by: herby@… Owned by: Daren Thomas
Priority: normal Component: YumlPreprocessorMacro
Severity: normal Keywords:
Cc: Trac Release: 0.12

Description

Here I include my changes to preprocessor macro. Urlencoding seems to be neede unlike the comment in actual version, diagrams with #comments did not work (no automatic urlenconding happened), so it is there explicitly.

It adds possibility to add line like: # pragma scruffy;dir:tb;scale:125 # into the diagram and its contents is taken into url.

Attachments (1)

YumlPreprocessor.py (2.8 KB) - added by anonymous 6 years ago.

Download all attachments as: .zip

Change History (9)

comment:1 Changed 6 years ago by anonymous

I could not post the file... rejected as spam.

Changed 6 years ago by anonymous

Attachment: YumlPreprocessor.py added

comment:2 Changed 6 years ago by anonymous

I finally managed to upload the file after removing all http:// from comments...

comment:3 Changed 6 years ago by anonymous

After awhile of using it, a little quirk appeared with spaces shown as pluses, so quote_plus should in fact be only quote`. Otherwise it works nicely for me.

comment:4 Changed 6 years ago by Daren Thomas

Status: newassigned

Hi Herby, I have committed your code, changing all quote_plus calls to quote. Is this what you mean? Would you mind checking this out and testing it for me? Thank you!

comment:5 in reply to:  4 Changed 6 years ago by herby@…

Replying to dthomas:

Hi Herby, I have committed your code, changing all quote_plus calls to quote. Is this what you mean? Would you mind checking this out and testing it for me? Thank you!

Yes, this is what I meant (there should have been just two of them, both in yuml_url function).

Well, since it is identical to what I actually use (apart from http:// in comments, which I removed just ad-hoc to be able to post it in a copy I downloaded to my desktop, not in the original; and which do not change functionality) (I thought you would like to have as little changes as possible and commit it with those http:// parts re-added, so that diff is smaller, but ok, you took it verbatim :-) ), I am actually testing it by simply using it.

So far it works fine (even spaces are now spaces not pluses which was the case with quote_plus).

comment:6 Changed 6 years ago by Daren Thomas

Great. I will run a small test myself and then resolve this as fixed. Thank you very much for posting the change!

comment:7 Changed 5 years ago by Ryan J Ollos

Resolution: fixed
Status: assignedclosed

comment:8 Changed 5 years ago by Ryan J Ollos

Btw, I closed this because it looked like someone just forgot to do that, but please correct if I'm wrong.

Modify Ticket

Change Properties
Set your email in Preferences
Action
as closed The owner will remain Daren Thomas.
The resolution will be deleted.

Add Comment


E-mail address and name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.