#9272 closed enhancement (fixed)
commit request: pragma to be able to set dir, scale etc.
Reported by: | Owned by: | Daren Thomas | |
---|---|---|---|
Priority: | normal | Component: | YumlPreprocessorMacro |
Severity: | normal | Keywords: | |
Cc: | Trac Release: | 0.12 |
Description
Here I include my changes to preprocessor macro. Urlencoding seems to be neede unlike the comment in actual version, diagrams with #comments did not work (no automatic urlenconding happened), so it is there explicitly.
It adds possibility to add line like:
# pragma scruffy;dir:tb;scale:125 #
into the diagram and its contents is taken into url.
Attachments (1)
Change History (9)
comment:1 Changed 13 years ago by
Changed 13 years ago by
Attachment: | YumlPreprocessor.py added |
---|
comment:2 Changed 13 years ago by
I finally managed to upload the file after removing all http:// from comments...
comment:3 Changed 13 years ago by
After awhile of using it, a little quirk appeared with spaces shown as pluses, so
quote_plus should in fact be only
quote`. Otherwise it works nicely for me.
comment:4 follow-up: 5 Changed 13 years ago by
Status: | new → assigned |
---|
Hi Herby, I have committed your code, changing all quote_plus
calls to quote
. Is this what you mean? Would you mind checking this out and testing it for me? Thank you!
comment:5 Changed 13 years ago by
Replying to dthomas:
Hi Herby, I have committed your code, changing all
quote_plus
calls toquote
. Is this what you mean? Would you mind checking this out and testing it for me? Thank you!
Yes, this is what I meant (there should have been just two of them, both in yuml_url function).
Well, since it is identical to what I actually use (apart from http:// in comments, which I removed just ad-hoc to be able to post it in a copy I downloaded to my desktop, not in the original; and which do not change functionality) (I thought you would like to have as little changes as possible and commit it with those http:// parts re-added, so that diff is smaller, but ok, you took it verbatim :-) ), I am actually testing it by simply using it.
So far it works fine (even spaces are now spaces not pluses which was the case with quote_plus).
comment:6 Changed 13 years ago by
Great. I will run a small test myself and then resolve this as fixed. Thank you very much for posting the change!
comment:7 Changed 13 years ago by
Resolution: | → fixed |
---|---|
Status: | assigned → closed |
comment:8 Changed 13 years ago by
Btw, I closed this because it looked like someone just forgot to do that, but please correct if I'm wrong.
I could not post the file... rejected as spam.