Opened 7 years ago

Closed 17 months ago

Last modified 17 months ago

#9282 closed defect (fixed)

Announcer will not send in html

Reported by: paul@… Owned by: Steffen Hoffmann
Priority: low Component: AnnouncerPlugin
Severity: normal Keywords: database API
Cc: Ryan J Ollos, Robert Corsaro Trac Release: 0.11


I am running trac 0.13 (upgraded today) + announcer 0.11.1-r10458

all previous versons will / have never done this.

there are plenty of hits on this issue with no clear resolution.

also announcer latest developer trunk 0.12 once compiles etc the environment would not allow an upgrade (attribute errors etc)

thus i backed of to 0.11.1-r10458

i can provide login access to the server if nessesary.

any help would be appreciated.

Attachments (0)

Change History (7)

comment:1 Changed 6 years ago by anonymous

Hey Paul, just to make it interesting, one of our TRAC projects is sending me messages in plain text AND html - one of each.

I think the Plain Text is from me being on the global CCall. And the HTML is from my announcer subscription to all activity.

Did you go into your user preferences and change your e-mail announcer preference to HTML?

comment:2 Changed 6 years ago by Steffen Hoffmann

Cc: Ryan J Ollos Robert Corsaro added; anonymous removed
Keywords: needinfo database API added
Owner: changed from Robert Corsaro to Steffen Hoffmann
Priority: normallow

Thanks for the report.

But I'm afraid that you rather get bitten by several unrelated issues, so your description is not very helpful for pushing a solution. I'll step it down priority-wise to give room for the other, better documented issues, that may even reflect some/all of the issues that you experienced. We already know much more now i.e. about db upgrade issues: See and follow #5774 and #9742 instead.

Ultimately, if you got around this by now due to local installation/configuration issues, close this ticket yourself, please.

comment:3 Changed 5 years ago by Steffen Hoffmann

Keywords: needinfo removed

Just noticed, that EmailDistributer._get_preferred_format still looks into Trac db table session_attribute for user's preferred format.

This is the old, now unsupported preference store, and plainly wrong. We need to replace it with the complementary lookup done in announcer.model.SubscriptionAttribute.

Understand, that I strongly encourage replacement of the potentially erroneous code, but won't care for fixing the old code. The OP revision is even before the new subscription model (db schema revision <3). The current db schema (revision 6, almost identical to 5, short upgrade path from 4) has been fixed for good reasons, mostly to overcome previous errors and limitations, and anything else is obsolete now.

comment:4 Changed 5 years ago by Steffen Hoffmann

(In [12346]) TracAnnouncer: Read the notification format from subscriptions, refs #9282.

Now EmailDistributor cares for the preferred format, that is configured per user in the subscription db table, obsoleting related 'announcer_email_format_<realm>' entries stored in session_attribute db table before.

While this is yet another regression, because this setting has been per target (resource) realm before, in theory it could even be more fine-grained. In fact, its possible to store the preferred format per subscriber in subscription. Only it is unified per transport for now, and I see no real value in changing this, yet.

comment:5 Changed 17 months ago by Ryan J Ollos

Owner: Steffen Hoffmann deleted

comment:6 Changed 17 months ago by Ryan J Ollos

Resolution: fixed
Status: newclosed

comment:7 Changed 17 months ago by Ryan J Ollos

Owner: set to Steffen Hoffmann

Modify Ticket

Change Properties
Set your email in Preferences
as closed The owner will remain Steffen Hoffmann.
The resolution will be deleted.

Add Comment

E-mail address and name can be saved in the Preferences.

Note: See TracTickets for help on using tickets.