error: global name 'pid' is not defined

[falkb]

Came across this traceback:

Traceback (most recent call last):
  File "build\bdist.win32\egg\trac\wiki\formatter.py", line 717, in _macro_formatter
    return macro.process(args, in_paragraph=True)
  File "build\bdist.win32\egg\trac\wiki\formatter.py", line 304, in process
    text = self.processor(text)
  File "build\bdist.win32\egg\trac\wiki\formatter.py", line 291, in _macro_processor
    text)
  File "build\bdist.win32\egg\tracjsgantt\tracjsgantt.py", line 1106, in expand_macro
    tasks = self._add_tasks(options)
  File "build\bdist.win32\egg\tracjsgantt\tracjsgantt.py", line 1068, in _add_tasks
    self._schedule_tasks(options)
  File "build\bdist.win32\egg\tracjsgantt\tracjsgantt.py", line 735, in _schedule_tasks
    _schedule_task_alap(t)
  File "build\bdist.win32\egg\tracjsgantt\tracjsgantt.py", line 618, in _schedule_task_alap
    finish = _earliest_successor(t, _ancestor_finish(t))
  File "build\bdist.win32\egg\tracjsgantt\tracjsgantt.py", line 604, in _earliest_successor
    % (t['id'], pid, pid))
NameError: global name 'pid' is not defined

Seems some safety checks are missing in the code

[falkb]

not sure if the logging is as desired now but this makes the chart working again:

C:/projects/tracjsganttplugin/0.11/tracjsgantt/tracjsgantt.py

@@ -598 +598 @@
                             if start == None or s < start:
                                 start = s
                         else:
+                          pid = int(t[self.fields['parent']])
+                          if pid != 0:
                             self.env.log.info("""Ticket %s has parent %s
                                                  but %s is not in the chart.
                                                  Ancestor deadlines ignored."""
@@ -680 +682 @@
                             if finish == None or f > finish:
                                 finish = f
                         else:
+                          pid = int(t[self.fields['parent']])
+                          if pid != 0:
                             self.env.log.info("""Ticket %s has parent %s
                                                  but %s is not in the chart.
                                                  Ancestor deadlines ignored."""

[Chris Nelson]

There was a cut-and-paste error in the code but the patch does not address it properly. The messages were revised in [10812].