[Patch] The custom fields for start and end date should be required
|Reported by:||Ryan J Ollos||Owned by:||Chris Nelson|
It seems like all of the custom fields are optional except for start and finish. Is there any use case or utility of the chart if these aren't defined? If not, and we checked for and threw an error when they aren't defined, it would be safe to omit checks such as
This will lead into some other refactoring ideas I would like to discuss later on, in order to improve the robustness of the code.
183 183 for field in fields: 184 184 self.fields[field] = self.config.get('trac-jsgantt', 185 185 'fields.%s' % field) 186 187 188 189 190 191 192 193 194 186 195 187 196 # This is the format of start and finish in the Trac database 188 197 self.dbDateFormat = str(self.config.get('trac-jsgantt', 'date_format'))
Change History (6)
comment:2 Changed 5 years ago by
|Summary:||The custom fields for start and end date should be required → [Patch] The custom fields for start and end date should be required|