with IE9: chart doesn't resize to web page width

[falkb]

Automatic resizing to page width works with Firefox but the gannt chart has a fixed size of visible 970 pixels using Internet Explorer 9.0.8112.16421.

[falkb]

uhm... I use latest svn revision of the plugin which is 10855

[falkb]

more precise: the chart resizes to the window size only on reload of the page displayed in the browser window, but not on just a resize of the browser window.

[falkb]

Replying to falkb:

more precise: the chart resizes to the window size only on reload of the page displayed in the browser window, but not on just a resize of the browser window.

That's the behaviour with Firefox.

Actual problem: With IE, it doesn't resize on reload of the page either

[falkb]

The following patch fixes a runtime error where g was not defined and that newline after Draw() prevented from really setting the resize handler.

Now the event handler is really called if you resize the browser window! Resizing is sensibly slower now. Though we just get to the next bug, because calling Draw() in the handler function is not enough. Maybe you have an idea what else has to be called? I suspect DrawDependencies() at least as well...

tracjsganttplugin/0.11/tracjsgantt/tracjsgantt.py

@@ -174 +174 @@
         text += 'var t;\n'
         text += 'if (window.addEventListener){\n'
         text += '  window.addEventListener("resize", ' + \
-            'function() { g.Draw();\n }, false);\n'
+            'function() { '+self.GanttID+'.Draw(); }, false);\n'
         text += '} else {\n'
         text += '  window.attachEvent("onresize", ' + \
-            'function() { g.Draw();\n });\n'
+            'function() { '+self.GanttID+'.Draw(); });\n'
         text += '}\n'
         return text

[Chris Nelson]

(In [11117]) Fix up resize handling. Refs #9509.

I can't test IE behavior easily but this works on FF.

[falkb]

Cool, FF works pretty well now, reload isn't necessary anymore, resizing the window is enough to make the chart resize. IE still doesn't resize at all and remains with that default size, for both, reload and resize of the browser window. Also after the necessary fix for [11117] (since :

tracjsganttplugin/tracjsgantt/tracjsgantt.py

@@ -183 +183 @@
             'function() { '+self.GanttID+'.Draw(); '
         if options['showdep']:
             text += self.GanttID+'.DrawDependencies();'
-        text += '}, false);\n'
+        text += '});\n'
         text += '}\n'
         return text

[Chris Nelson]

Replying to falkb:

Cool, FF works pretty well now, reload isn't necessary anymore, resizing the window is enough to make the chart resize. IE still doesn't resize at all and remains with that default size, for both, reload and resize of the browser window. Also after the necessary fix for [11117] (since :

tracjsganttplugin/tracjsgantt/tracjsgantt.py

@@ -183 +183 @@
             'function() { '+self.GanttID+'.Draw(); '
         if options['showdep']:
             text += self.GanttID+'.DrawDependencies();'
-        text += '}, false);\n'
+        text += '});\n'
         text += '}\n'
         return text

I'm confused. Are you saying that I need to remove the false?

[falkb]

yes, look here: ​http://help.dottoro.com/ljorlllt.php

[falkb]

we need to remove the false but still resizing doesn't work and I don't know why and can't find something on the internet about that :(

[falkb]

Replying to falkb:

(since

this was just a copy'n'paste mistake

[Chris Nelson]

(In [11120]) Remove bad argument to attachEvent. Refs #9509.

[falkb]

I found ​http://www.codingforums.com/archive/index.php/t-228036.html where people discuss about that resize handler mess with all those different browsers. In the end it seems to me, for getting it work with IE, the resize handler function needs to get some widths from certain inner objects and set the value to the object which is to be resized... too tired for looking through now...

[falkb]

This fixes the chart width in IE for reload and resize, and by using this fix, FF and IE shows equal behaviour now!:

tracjsganttplugin/tracjsgantt/htdocs/jsgantt.js

@@ -1693 +1693 @@
          {
          // 95% of overall window width
          width = window.innerWidth * 0.95 + 'px';
+         } else {
+             width = document.documentElement.clientWidth * 0.95 + 'px';
          }
 
      vDiv.style.width = width;

P.S.: I still see another problem with resize, I mean the vFormat selection always resets to 'day' after you've resized. One must always click the radiobutton to e.g. 'week' again. Somehow changeFormat() or setFormat() is connected with the onclick handler, only. I can see this problem with both browsers, FF and IE. What to do here now?

[Chris Nelson]

(In [11133]) Handle width in IE. Refs #9509.

[anonymous]

Replying to falkb:

P.S.: I still see another problem with resize, I mean the vFormat selection always resets to 'day' after you've resized. One must always click the radiobutton to e.g. 'week' again. Somehow changeFormat() or setFormat() is connected with the onclick handler, only.

This patch fixes it this way:

tracjsganttplugin/0.11/tracjsgantt/tracjsgantt.py

@@ -177 +177 @@
         text += '  window.addEventListener("resize", ' + \
             'function() { ' + self.GanttID+'.Draw(); '
         if options['showdep']:
-            text += self.GanttID+'.DrawDependencies();'
+            text += 'JSGantt.changeFormat("'+defaultFormat+'",'+self.GanttID+');'
         text += '}, false);\n'
         text += '} else {\n'
         text += '  window.attachEvent("onresize", ' + \
             'function() { '+self.GanttID+'.Draw(); '
         if options['showdep']:
-            text += self.GanttID+'.DrawDependencies();'
+            text += 'JSGantt.changeFormat("'+defaultFormat+'",'+self.GanttID+');'
         text += '});\n'
         text += '}\n'
         return text

(Note: changeFormat internally calls DrawDependencies)

If no special radiobutton was clicked before, the chart keeps its format (as set in trac.ini) and doesn't switch to "day" anymore. This should be enough for most of all situations.

=> resolved="fixedforme" :-)

[Chris Nelson]

Replying to anonymous:

Replying to falkb:

P.S.: I still see another problem with resize, I mean the vFormat selection always resets to 'day' after you've resized. One must always click the radiobutton to e.g. 'week' again. Somehow changeFormat() or setFormat() is connected with the onclick handler, only.

This patch fixes it this way: ... If no special radiobutton was clicked before, the chart keeps its format (as set in trac.ini) and doesn't switch to "day" anymore. This should be enough for most of all situations.

=> resolved="fixedforme" :-)

Thanks but I really want to remember the format. I have a general idea how to do that that may even work across reloads of the page.