Modify

Opened 5 years ago

Closed 5 years ago

Last modified 4 years ago

#9600 closed task (fixed)

Upgrade to jQuery UI 1.8.16

Reported by: Ryan J Ollos Owned by: Ryan J Ollos
Priority: normal Component: DateFieldPlugin
Severity: normal Keywords: jquery-ui
Cc: Steffen Hoffmann, Robert Corsaro Trac Release: 0.11

Description

Upgrade the 0.11 version of the plugin to jQuery UI 1.8.16.

Attachments (0)

Change History (10)

comment:1 Changed 5 years ago by Ryan J Ollos

(In [11024]) Refs #9600: (1.0.4)

  • Upgrade to jQuery UI 1.8.16.

comment:2 Changed 5 years ago by Ryan J Ollos

Cc: Steffen Hoffmann Robert Corsaro added; anonymous removed
Resolution: fixed
Status: newclosed

I tested this in a Trac 0.11.7 dev environment and have it running on my Trac 0.12.2 instance. Both seem to be working well.

comment:3 Changed 5 years ago by Ryan J Ollos

(In [11026]) Refs #9600: Removed the jQuery library. It is provided by Trac, so we don't want to include it again. Including a different version can result in conflicts.

comment:4 Changed 5 years ago by Ryan J Ollos

(In [11242]) Refs #9600: Images needs to be located within the css directory, because they are referenced by a relative path in jquery-ui-1.8.16.custom.css.

comment:5 Changed 5 years ago by Ryan J Ollos

(In [11243]) Refs #9600: jQuery UI 1.8.16 doesn't work jQuery distributed with Trac 0.11.x, so the 0.11 branch is being renamed as the 0.12 branch. A new 0.11 branch will be created at a revision prior to the jQuery UI 1.8.16 upgrade.

comment:6 Changed 5 years ago by Ryan J Ollos

(In [11244]) Refs #9600: A new 0.11 branch is being created from r11023 of the old 0.11 branch (prior to the upgrade to jQuery UI 1.8.16.

comment:7 Changed 5 years ago by Ryan J Ollos

(In [11245]) Refs #9600: Same as [11242], for the 0.11 branch: Images needs to be located within the css directory, because they are referenced by a relative path in jquery-ui-1.8.16.custom.css.

For both the 0.11 and 0.12 branches, setup.py needed to be modified to account for the new location of this package data.

comment:8 Changed 5 years ago by Ryan J Ollos

Trying to be more careful going forward. The 0.11 branch has been tested with Trac 0.11.0 and the 0.12 branch has been tested with Trac 0.12.0.

I guess the question is now, do we really need separate 0.11 and 0.12 branches? Well, if the 0.12 branch is to use the more recent jQuery UI, then I think the answer is yes, because too much logic would be needed to select between the different jQuery components. The question then becomes, is it worthwhile to use jQuery UI 1.8.16 with Trac 0.12. I've seen a lot of jQuery UI conflicts, so without knowing any better, I'd say we are safest to try and get all of the 0.12 plugins using jQuery UI 1.8.16 (or, actually 1.8.17 is available now). I'd really appreciate getting some guidance on this though.

hasienda's recent guidance about the need to test with 0.11.0 got me thinking more about this and hopefully I'm doing the right things now to ensure a stable plugin.

My attention now is on #7617 because of the performance issue seen there. I've experiment there with no success, so I think I'll have to leave it until I know more, or someone offers guidance.

comment:9 in reply to:  8 Changed 5 years ago by Steffen Hoffmann

Replying to rjollos:

Trying to be more careful going forward. The 0.11 branch has been tested with Trac 0.11.0 and the 0.12 branch has been tested with Trac 0.12.0.

+1 for this approach. Definitely he way to go to make users and fellow developers happy. :-)

comment:10 in reply to:  8 Changed 5 years ago by Ryan J Ollos

Replying to rjollos:

I guess the question is now, do we really need separate 0.11 and 0.12 branches? Well, if the 0.12 branch is to use the more recent jQuery UI, then I think the answer is yes, because too much logic would be needed to select between the different jQuery components. The question then becomes, is it worthwhile to use jQuery UI 1.8.16 with Trac 0.12. I've seen a lot of jQuery UI conflicts, so without knowing any better, I'd say we are safest to try and get all of the 0.12 plugins using jQuery UI 1.8.16 (or, actually 1.8.17 is available now). I'd really appreciate getting some guidance on this though.

Recent thoughts have me reversing course on this. I'm now thinking that it would be better to have one code line, even if 0.11 and 0.12 are using different versions of jQuery UI. We can select between them by importing the Trac version.

I also agree with utilizing a trunk and branches repository layout, as hasienda suggested might be the new standard repository layout for t-h.o plugins. I'm thinking that we could let the current 0.11 be the trunk, and utilize 0.12 as a development line leading to a version 2.0 of this plugin. In particular, I could push my work from #7617 into this development line.

Modify Ticket

Change Properties
Set your email in Preferences
Action
as closed The owner will remain Ryan J Ollos.
The resolution will be deleted. Next status will be 'reopened'.

Add Comment


E-mail address and name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.