Modify

Opened 5 years ago

Closed 4 years ago

Last modified 4 years ago

#9732 closed defect (fixed)

Forum sort direction not working when set from config/trac.ini

Reported by: Joseph Coffland Owned by: Radek Bartoň
Priority: normal Component: DiscussionPlugin
Severity: normal Keywords: forum sort direction
Cc: Trac Release: 0.11

Description (last modified by Ryan J Ollos)

I couldn't get my forums to sort correctly with the forum_sort option in the trac configuration file. I search around in the code and found the problem. The variable forum_sort_direction is not being used correctly in api.py. I've attached a patch.

Otherwise, great plugin. Thanks!

Attachments (1)

discussionplugin_0.11_forum_sort_direction.patch (1011 bytes) - added by Joseph Coffland 5 years ago.
Very simple patch to fix bug

Download all attachments as: .zip

Change History (7)

Changed 5 years ago by Joseph Coffland

Very simple patch to fix bug

comment:1 Changed 5 years ago by Radek Bartoň

Thank you.

comment:2 Changed 5 years ago by Joseph Coffland

No problem. Glad to be able to contribute something.

comment:3 Changed 5 years ago by Ryan J Ollos

Description: modified (diff)

comment:4 Changed 4 years ago by Ryan J Ollos

Resolution: fixed
Status: newclosed

(In [12143]) Fixes #9732: The forum_sort_direction and topic_sort_direction options were not being respected. Thanks to jcoffland for the initial patch.

comment:5 Changed 4 years ago by Ryan J Ollos

If you are able, please upgrade to r12143 and report back your findings. Thanks.

comment:6 in reply to:  5 Changed 4 years ago by sdegrande

Replying to rjollos:

If you are able, please upgrade to r12143 and report back your findings. Thanks.

Works well. Thanks

Modify Ticket

Action
as closed The owner will remain Radek Bartoň.
The resolution will be deleted. Next status will be 'reopened'.

Add Comment


E-mail address and name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.