Opened 13 years ago
Closed 12 years ago
#9760 closed enhancement (fixed)
Add compatibility with Trac 0.11.0
| Reported by: | Ryan J Ollos | Owned by: | Chris Nelson |
|---|---|---|---|
| Priority: | normal | Component: | TracJsGanttPlugin |
| Severity: | normal | Keywords: | |
| Cc: | Steffen Hoffmann | Trac Release: | 0.11 |
Attachments (1)
Change History (6)
Changed 13 years ago by
| Attachment: | th9600-trac0.11.0-tracjsgantt0.9-r11182.patch added |
|---|
comment:1 Changed 13 years ago by
comment:2 follow-up: 3 Changed 12 years ago by
Experience has taught me that adding an install_requires for Trac is not a good idea, so I suggest ignoring the part of the patch that effects setup.py.
#10405 closed as a duplicate. I'd be happy to commit the patch if you are okay with it.
comment:3 follow-up: 4 Changed 12 years ago by
Replying to rjollos:
Experience has taught me that adding an
install_requiresfor Trac is not a good idea, so I suggest ignoring the part of the patch that effectssetup.py.#10405 closed as a duplicate. I'd be happy to commit the patch if you are okay with it.
If it still applies cleanly, go for it.
comment:4 Changed 12 years ago by
Replying to anonymous:
Replying to rjollos:
Experience has taught me that adding an
install_requiresfor Trac is not a good idea, so I suggest ignoring the part of the patch that effectssetup.py.#10405 closed as a duplicate. I'd be happy to commit the patch if you are okay with it.
If it still applies cleanly, go for it.
That was me. I forgot to log in.
comment:5 Changed 12 years ago by
| Resolution: | → fixed |
|---|---|
| Status: | new → closed |
(In [12096]) Fixes #9760, Refs #10405: Restore compatibility back to Trac 0.11 by adding a fallback for when trac.util.text.javascript_quote is not available (Trac < 0.11.3). Copied from hasienda's patch in [11200].
Beware of #9892 before jumping to the conclusion that the plugin doesn't work. The sample seems to be broken, but ordinary usage of the plugin seems to be okay.
Replying to rjollos:
Cool. Thanks. I'll try to merge that this weekend.