Modify

Opened 5 years ago

Closed 4 years ago

#9760 closed enhancement (fixed)

Add compatibility with Trac 0.11.0

Reported by: Ryan J Ollos Owned by: Chris Nelson
Priority: normal Component: TracJsGanttPlugin
Severity: normal Keywords:
Cc: Steffen Hoffmann Trac Release: 0.11

Description

The attached patch allows for installation with Trac 0.11.0. This is copied from hasienda's work in [11200]

Attachments (1)

th9600-trac0.11.0-tracjsgantt0.9-r11182.patch (1.8 KB) - added by Ryan J Ollos 5 years ago.

Download all attachments as: .zip

Change History (6)

Changed 5 years ago by Ryan J Ollos

comment:1 in reply to:  description Changed 5 years ago by anonymous

Replying to rjollos:

The attached patch allows for installation with Trac 0.11.0. This is copied from hasienda's work in [11200]

Cool. Thanks. I'll try to merge that this weekend.

comment:2 Changed 4 years ago by Ryan J Ollos

Experience has taught me that adding an install_requires for Trac is not a good idea, so I suggest ignoring the part of the patch that effects setup.py.

#10405 closed as a duplicate. I'd be happy to commit the patch if you are okay with it.

comment:3 in reply to:  2 ; Changed 4 years ago by anonymous

Replying to rjollos:

Experience has taught me that adding an install_requires for Trac is not a good idea, so I suggest ignoring the part of the patch that effects setup.py.

#10405 closed as a duplicate. I'd be happy to commit the patch if you are okay with it.

If it still applies cleanly, go for it.

comment:4 in reply to:  3 Changed 4 years ago by Chris Nelson

Replying to anonymous:

Replying to rjollos:

Experience has taught me that adding an install_requires for Trac is not a good idea, so I suggest ignoring the part of the patch that effects setup.py.

#10405 closed as a duplicate. I'd be happy to commit the patch if you are okay with it.

If it still applies cleanly, go for it.

That was me. I forgot to log in.

comment:5 Changed 4 years ago by Ryan J Ollos

Resolution: fixed
Status: newclosed

(In [12096]) Fixes #9760, Refs #10405: Restore compatibility back to Trac 0.11 by adding a fallback for when trac.util.text.javascript_quote is not available (Trac < 0.11.3). Copied from hasienda's patch in [11200].

Beware of #9892 before jumping to the conclusion that the plugin doesn't work. The sample seems to be broken, but ordinary usage of the plugin seems to be okay.

Modify Ticket

Action
as closed The owner will remain Chris Nelson.
The resolution will be deleted. Next status will be 'reopened'.

Add Comment


E-mail address and name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.