Modify

Opened 8 years ago

Closed 4 years ago

#1079 closed enhancement (wontfix)

Use link under the View Tickets tab instead of Custom Query tab

Reported by: anonymous Owned by: tonin
Priority: normal Component: BatchModifyPlugin
Severity: normal Keywords: navigation tab
Cc: jujuj Trac Release: 0.11

Description

Adding yet another tab in the navigation bar can become problematic for any user having the TRAC_ADMIN permissions: the navigation bar becomes too long.

Wouldn't it be possible to use the same Custom Query link below the View Tickets link as in the default Trac behaviour ?

Attachments (0)

Change History (9)

comment:1 Changed 8 years ago by tonin

  • Owner changed from b to ashwin_phatak

comment:2 Changed 7 years ago by anonymous

It would be great if this ticket could be fixed, Im getting a way to long nav menu.

comment:3 Changed 7 years ago by tonin

  • Owner changed from ashwin_phatak to tonin
  • Status changed from new to assigned

The problem to the proposed behaviour is that the Custom Query link is taken care of inside the process_request method of the Trac ReportModule class (see trac/ticket/report.py code):

# Kludge: only show link to custom query if the query module is actually
# enabled
from trac.ticket.query import QueryModule
if req.perm.has_permission('TICKET_VIEW') and \
   self.env.is_component_enabled(QueryModule):
    req.hdf['report.query_href'] = req.href.query()

We see a direct test to the QueryModule to see if it's enabled.. However, the BatchModifyModule needs the QueryModule to be disabled to work. :(

To solve this problem, one should patch Trac, which is not so recommended, or make the BatchModifyModule behave like if it was the QueryModule which is enabled. Not sure how this last option is feasable. Anyone has a clue?

comment:4 Changed 7 years ago by coling

  • Resolution set to wontfix
  • Status changed from assigned to closed

This is solved in 0.11 via the use of a filter to adjust the output of the built in query page rather than actually create it's own one.

It would be pretty tricky to fix it properly for 0.10 without some kind of ugly hack or patch to Trac itself. So I think this can be closed...

If someone feels strongly to the contrary, please reopen.

comment:5 Changed 5 years ago by anonymous

  • Cc jujuj added

comment:6 Changed 4 years ago by anonymous

If someone feels strongly to the contrary, please reopen.
rosetta stone french

comment:7 Changed 4 years ago by anonymous

  • Trac Release changed from 0.10 to 0.11

The problem to the proposed behaviour is that the Custom Query link is taken care of inside the process_request method of the Trac ReportModule classrosetta stone french

comment:8 Changed 4 years ago by anonymous

  • Resolution wontfix deleted
  • Status changed from closed to reopened

comment:9 Changed 4 years ago by CuriousCurmudgeon

  • Resolution set to wontfix
  • Status changed from reopened to closed

This looks like it was reopened by a spam bot.

Add Comment

Modify Ticket

Action
as closed .
The resolution will be deleted. Next status will be 'reopened'.
Author


E-mail address and user name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.