Ticket #3851 (closed defect: fixed)

Opened 3 years ago

Last modified 4 months ago

TAGS_VIEW not showing page tags along for anonymous

Reported by: izzy Assigned to: otaku42
Priority: normal Component: TagsPlugin
Severity: major Keywords: wiki page
Cc: Trac Release: 0.11

Description

We have granted TAGS_VIEW to anonymous. So without logging in, the "Tags" menu item in main_nav shows up, and the tags are also listed there. However, when viewing some Wiki article, its tags are not displayed.

Attachments

tractags-fix-tags-anonymous.patch (0.5 kB) - added by quad on 12/01/08 21:41:08.
Fixes the bug where tags don't show up when not authenticated.

Change History

11/21/08 23:12:16 changed by alerocha

I fixed it in my environment.

The point is that the list of tags must appear before the buttons (div with class called buttons wich show the actions) but this div is not in the string when the user has no permission to modify or delete wiki pages.

So the code that puts the cloud into string must be changed

TracTags => wiki.py Line 99: return stream | Transformer('//div[@class="buttons"]').before(insert)

If another div will be used instead class=buttons the bug is fixed.

In my case I changed the css too

12/01/08 17:27:56 changed by quad

  • severity changed from normal to major.

Experiencing this behavior also. Sounds like an important defect to me as it completely prevents visitors from viewing tags (default configuration, anonymous users). Please change back if you don't agree.

I am myself not too sure of what must be changed exactly, but until it's fixed I'll give it a try at modifying my local working copy of trunk.

12/01/08 21:41:08 changed by quad

  • attachment tractags-fix-tags-anonymous.patch added.

Fixes the bug where tags don't show up when not authenticated.

12/01/08 21:44:31 changed by quad

Just attached a patch that make the tags reappear. Basically, it adds the tags section relative to the main page section, rather that to the div containing the buttons.

01/12/10 09:47:46 changed by otaku42

  • owner changed from athomas to otaku42.

I cannot reproduce the described issue with r7373 and Trac 0.11.6. Can someone please confirm that this issue still exists for them, and that the patch attached to this ticket is required for them to fix it?

01/12/10 18:36:29 changed by izzy

As the reporter, this should probably be my task - but I have no longer access to those environments as I "left that company" and switched to a new project, sorry.

01/13/10 07:25:57 changed by otaku42

  • status changed from new to assigned.

Now I was able to reproduce the reported issue, comment:3 pointed me in the right direction :)

The issue occurs only for users that have TAGS_VIEW but not WIKI_MODIFY. There are no buttons without WIKI_MODIFY, thus the stream filter fails. The patch submitted by quad works as intended and fixes the issue, I'll commit it to the repos now.

01/13/10 07:56:07 changed by otaku42

  • status changed from assigned to closed.
  • resolution set to fixed.

(In [7384]) Fix bug where wiki page tags were not displayed for users that have TAGS_VIEW permission but not WIKI_MODIFY. Thanks to quad for the patch. Fixes #3851.

10/05/11 23:33:43 changed by hasienda

  • keywords set to wiki page.

#8467 has been closed as a duplicate of this ticket.

Add/Change #3851 (TAGS_VIEW not showing page tags along for anonymous)




Change Properties
Action